NumberFieldTest is slightly and subtly broken

Problem/Motivation

In NumberFieldTest::testNumberDecimalField you can find $this->assertRaw(round($value, 2) where $value is "-1234.5678. Now, round() creates a floating point value. assertRaw runsstrpos($this->drupalGetContent(), $raw).

http://php.net/strpos

If needle is not a string, it is converted to an integer and applied as the ordinal value of a character.

Opsie! Actually, strpos($haystack, round(-1234.5678, 2)) searches for the humble dot. (YES! We love PHP.) Check For kicks, try php -r 'var_dump(strpos(".", round(-1234.5678, 2)));' -- consequently, this test will pass for any page containing a dot.

Proposed resolution

Do not round the string. Easy!

Remaining tasks

User interface changes

API changes