While skimming through the code for some other issue, I noticed a few indentation errors in src/Form/EditorImageDialog.php. Code has 1-space indent instead of 2-space indent. Following is the relevant code:

    $form['attributes']['src'] = array(
     '#title' => $this->t('URL'),
     '#type' => 'textfield',
     '#default_value' => isset($image_element['src']) ? $image_element['src'] : '',
     '#maxlength' => 2048,
     '#required' => TRUE,
    );

CodeSniffer output:

--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
 78 | ERROR | Array indentation error, expected 6 spaces but found 5
 79 | ERROR | Array indentation error, expected 6 spaces but found 5
 80 | ERROR | Array indentation error, expected 6 spaces but found 5
 81 | ERROR | Array indentation error, expected 6 spaces but found 5
 82 | ERROR | Array indentation error, expected 6 spaces but found 5
--------------------------------------------------------------------------------

Patch Coming.

CommentFileSizeAuthor
#1 editor.module-2279217-1.patch918 bytescs_shadow
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cs_shadow’s picture

Status: Active » Needs review
FileSize
918 bytes
Wim Leers’s picture

Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Thanks!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed ab2df00 and pushed to 8.x. Thanks!

  • Commit ab2df00 on 8.x by alexpott:
    Issue #2279217 by cs_shadow: Fixed Indentation error in \Drupal\editor\...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: editor.module-2279217-1.patch, failed testing.

cs_shadow’s picture

Status: Needs work » Fixed

Silly testbot, its already committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.