Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
#2275491: CKEditor does not support the "readonly" attribute adds a work-around in Drupal because CKEditor does not yet natively support the readonly
attribute. Once https://dev.ckeditor.com/ticket/12036 lands, though, we will need to remove that work-around.
Proposed resolution
Wait for CKEditor 4.5 to be released, then remove the work-around from #2275491.
Steps to test
- Add a second language
- Enable Configuration Translation
- Add a Global: Text area to a view
- Translate that view
- Verify that the Source part for the text area is disabled
- Apply patch
- Clear browser cache
- Verify that the Source part for the text area is (still) disabled
Remaining tasks
- Wait.
- Remove work-around.
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#8 | ct-ckeditor-readonly.PNG | 98.03 KB | tstoeckler |
#7 | ckeditor_readonly_workaround_obsolete-2276187-7.patch | 943 bytes | Wim Leers |
Comments
Comment #1
Wim LeersComment #2
Wim LeersComment #3
Wim LeersComment #4
Wim LeersThis has now been fixed upstream: http://dev.ckeditor.com/ticket/12036#comment:7.
This is now blocked on the release of CKEditor 4.5, and Drupal 8 upgrading to that version.
Comment #5
Wim LeersYay, we're now actually updating to CKE 4.5: #2521820: Update CKEditor library to 4.5.3. So we'll be able to fix this soon.
Comment #6
Wim LeersComment #7
Wim Leers#2521820: Update CKEditor library to 4.5.3 and its blocker have landed! This means that the upstream bugfix is now also part of Drupal 8 HEAD. which means we can finally remove our workaround for this :)
Can be tested manually by adding this to
\Drupal\text\Plugin\Field\FieldWidget\TextareaWidget::formElement()
:… and going to
/node/add/article
. All of CKEditor's buttons should be disabled, except the Source button.Then apply the patch, and check that this is still the case.
Assigning to @tstoeckler for review, he advocated to add this work-around for the Content/Config Translation UI.
Comment #8
tstoecklerYup, this works as designed.
It is actually possible to see this in the UI now, without any patches (yay! :-))
Updated the issue summary.
Comment #9
tstoecklerComment #10
Wim LeersThat's one hell of an impressive screenshot of Inception-like nesting levels :D
Comment #11
Wim LeersComment #12
tstoecklerYeah, the usability of translating Views.... well, it doesn't exist basically. :-/
Comment #13
alexpottCommitted 073a3c6 and pushed to 8.0.x. Thanks!