Problem/Motivation

Currently comment form title <h2> and comment form <form> have same class 'comment-form'. This is bad for styling.

Proposed resolution

Change the comment form title to 'comment-form__title'.

CommentFileSizeAuthor
#2 shortcut-comment_form_title-2273191-2.patch514 bytesducktape
comment-form-title-class.png39.17 KBDragan Eror
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dragan Eror’s picture

Dragan Eror CreditAttribution: Dragan Eror commented
Issue summary: View changes
ducktape’s picture

ducktape CreditAttribution: ducktape commented
Status: Active » Needs review
FileSize
shortcut-comment_form_title-2273191-2.patch514 bytes

I've changed the title class in the wrapper template.

Dragan Eror’s picture

Dragan Eror CreditAttribution: Dragan Eror commented
Status: Needs review » Reviewed & tested by the community

Thanks @ducktape, looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: shortcut-comment_form_title-2273191-2.patch, failed testing.

Dragan Eror’s picture

Dragan Eror CreditAttribution: Dragan Eror commented
Status: Needs work » Needs review

2: shortcut-comment_form_title-2273191-2.patch queued for re-testing.

neardark’s picture

neardark CreditAttribution: neardark commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • Commit 4d34711 on 8.x by alexpott: 
    Issue #2273191 by ducktape | Dragan Eror: Comment form title class...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 4d34711 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.