Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We recently upgraded from 4.2 with patches to 4.4: #2039163: Update CKEditor library to 4.4.
4.4.4 has been released already: http://ckeditor.com/blog/CKEditor-4.4.4-Released.
No significant changes though, only bugfixes. It's not at all urgent to update, though we probably want to do that before beta 1, and of course definitely before RC.
See also:
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | ckeditor_4.4.4-2271051-16.patch | 2.95 MB | Wim Leers |
Comments
Comment #1
Wim LeersComment #2
catchComment #3
Wim Leers@catch: s/revisit before beta/beta target/ is fine, but I think we do want to keep "revisit before release candidate", because just before we tag an RC, we'll want to decide what version we'll ship in 8.0.0?
Also, the CKEditor library in core is a stable version, there's only been a single point release with bugfixes, so I'm not sure why this needs to be critical? We could ship Drupal 8 with the current CKEditor version without any problems! :)
I think it's just to have all the "upgrade library" child issues consistent in terms of priority?
Comment #4
catch@Wim if it's critical then we have to revisit it before release.
Personally I think we should aim to be on the latest stable release of all external libraries before RC, that gives us a chance to iron out any regressions the might introduce before cutting 8.0.0 instead of afterwards - with no js testing at all that's a big difference. There might be further upgrades after that, but starting the release with a clean slate at least means we don't have them hanging over our heads.
Comment #5
Wim LeersOk — thanks for the clarification :)
Comment #6
TJacksonVA CreditAttribution: TJacksonVA commentedIf we're going to do this, CKEditor just released (June 24, 2014) another point upgrade with bug fixes. The current release is 4.4.2. Here is a list of the bug fixes:
http://ckeditor.com/release/CKEditor-4.4.2
Comment #7
Wim Leers#6: yep, this issue exists to ensure we do this before shipping the RC, but they'll continue to update in the mean time; we don't need to update to every minor version right now :)
Thanks for reporting this though!
Comment #8
cosmicdreams CreditAttribution: cosmicdreams commentedChanging the title to reflect that intent. Should we postpone as well?
Comment #9
Wim Leers4.4.3 has been released now. It contains a security fix for the Preview plugin, which we don't use, so it doesn't affect us.
#8: We could; I'm not sure what's best. It's possible that one of the minor updates contains a compelling reason to update sooner, but for now, that's not the case.
Comment #10
Wim LeersThe CKEditor team reported at #2292035-10: CKEditor uses the automatically generated ID attribute for the body field in the ARIA label that an upstream bug has been fixed to fix an accessibility problem, and this will be available in CKEditor 4.4. Hence now we do have a good reason to update CKEditor, so we should, as soon as CKEditor 4.4.4 is available (which will be next week — see http://dev.ckeditor.com/query?group=status&milestone=CKEditor+4.4.4).
I've created a new issue to capture the next update: #2321583: Update CKEditor library to 4.5.5.
Comment #11
TJacksonVA CreditAttribution: TJacksonVA commentedSounds good, since moving to CKEditor 4.4.4 from 4.4.0 will give us a security fix, 3 new features and around 75 bug fixes. It's not a beta blocker, but it would be nice to get it in before beta 1.
They plan on releasing CKEditor 4.5 in the fall, so we could do the betas with the 4.4.x line, and then upgrade to the 4.5.x line before the RC.
Comment #12
Wim Leers#11: , to all of what you said :)
Comment #13
Wim LeersI think we only want #2321583: Update CKEditor library to 4.5.5 to be critical.
Comment #14
TJacksonVA CreditAttribution: TJacksonVA commentedCKEditor released CKEditor 4.4.4 today. It would be great if we could get this in before beta 1.
Comment #15
Wim LeersAbsolutely!
http://ckeditor.com/blog/CKEditor-4.4.4-Released
On it!
Comment #16
Wim LeersSlight changes to
core/assets/vendor/ckeditor/build-config.js(which is used to create Drupal 8's build of CKEditor), because CKEditor has made some additions to its repository for development, that we don't need to ship with Drupal 8. The changes are made in such a way that if you diff CKEditor's defaultbuild-config.jswith that of Drupal 8, the changes are minimal.Other than that minor and necessary change, this is simply a new build of the latest stable release of CKEditor (less than 24 hours young!), that will allow us to fix #2292035: CKEditor uses the automatically generated ID attribute for the body field in the ARIA label.
Comment #17
Wim LeersComment #18
cosmicdreams CreditAttribution: cosmicdreams commentedLooks good.
Comment #19
alexpottCommitted 36c0354 and pushed to 8.0.x. Thanks!
Comment #21
Wim LeersThat went fast! Thanks, cosmicdreams and alexpott! :)