Problem/Motivation

In #2080217: Polish entity toolbar visually we visually tweaked the Quick edit toolbar, it looks like we have lost some of that styling along the way. It looks like there is a box around the buttons? This box dilutes the intended visual styling by introducing another "box" element. I wonder if this was introduced on purpose or accidentally, and what we could do to resolve this problem.

Earlier agreed upon style:

Current style:

Proposed resolution

Remove the box around it, even if its only visually.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#11 2270251-patch-4.png15.68 KBOuti
#7 03.10.14 12:56-Bildschirmkopie.png37.39 KBcriscom
#4 2270251-4-Unwanted-box-around-CKEditor.patch984 bytesyvesvanlaer
toolbar-box-around-buttons.png31.24 KBBojhan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Issue tags: +CKEditor in core, +Spark

Haven't seen that yet, but that would definitely be a regression. Most likely suspect: #2039163: Update CKEditor library to 4.4.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Issue tags: +CSS, +frontend
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: A visual box around » Unwanted box around CKEditor, i.e. our CSS overrides no longer work (presumably since CKEditor 4.4 upgrade)
yvesvanlaer’s picture

yvesvanlaer CreditAttribution: yvesvanlaer commented
Status: Active » Needs review
Issue tags: +Amsterdam2014
FileSize
2270251-4-Unwanted-box-around-CKEditor.patch984 bytes

Hey all

The reason why the ckeditor got this unwanted border is because of a change in class names.
The code was already correct but it just got a wrong class name.

You'll find a patch attached.

criscom’s picture

criscom
Location Graz, Austria
CreditAttribution: criscom commented

Testing...

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#1874640: Rename edit module to quickedit

Hah! Silly me! I introduced this in #1874640: Rename edit module to quickedit. My bad. Thank you!

criscom’s picture

criscom
Location Graz, Austria
CreditAttribution: criscom commented
Related issues: -#1874640: Rename edit module to quickedit
FileSize
03.10.14 12:56-Bildschirmkopie.png37.39 KB

The border is no longer there. What I noticed is that once the page title is changed the quick edit UI doesn't reflect that change.

Part of the original title was "pge". This was changed to "page" but the quick edit UI still shows "pge".
I will open a separate issue for this.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

#7: Yes, thanks, that's indeed a separate issue.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2270251-4-Unwanted-box-around-CKEditor.patch, failed testing.

Outi queued 4: 2270251-4-Unwanted-box-around-CKEditor.patch for re-testing.

Outi’s picture

Outi CreditAttribution: Outi commented
FileSize
2270251-patch-4.png15.68 KB

It looks good for me (besides the title problem criscom reported).

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs work » Reviewed & tested by the community

Was RTBC; testbot was just broken for a short while. Back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 51e37ae and pushed to 8.0.x. Thanks!

  • alexpott committed 51e37ae on 8.0.x 
    Issue #2270251 by yvesvanlaer | Bojhan: Unwanted box around CKEditor, i....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.