Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The ConfigImporter contains methods that are unused, unnecessary public, a few spelling mistakes and the reInjectMe class does not match the constructor.
Comment | File | Size | Author |
---|---|---|---|
#12 | d8.configimporter-12.patch | 6.33 KB | amitgoyal |
d8.configimporter.patch | 5.6 KB | alexpott | |
Comments
Comment #1
Gábor HojtsyLooks good to me, especially the typehint/config fixes :) I can see how some of those public methods should not be exposed to the public.
Comment #3
Gábor Hojtsyd8.configimporter.patch queued for re-testing.
Comment #4
Gábor HojtsyThis had a thousands of random fails in the automated retest. Green again.
Comment #6
alexpottHEAD was failing due to #2239969-27: Session of (UI) test runner leaks into web tests
Comment #7
alexpottd8.configimporter.patch queued for re-testing.
Comment #8
Gábor HojtsyYeah should be back to RTBC.
Comment #10
alexpottDiskspace issues :(
9800673 Requested by test client #1848.
Comment #11
alexpottd8.configimporter.patch queued for re-testing.
Comment #12
amitgoyal CreditAttribution: amitgoyal commentedPlease review attached patch which also fixes 'Inline control structure' issue on line #267.
Comment #13
Gábor HojtsyThat looks like a good additional fix.
Comment #14
catchCommitted/pushed to 8.x, thanks!