Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#11 | 2267641-11.patch | 4.78 KB | rpayanm |
#11 | 2267641-interdiff.txt | 3.18 KB | rpayanm |
Comments
Comment #1
jesse.d CreditAttribution: jesse.d commentedI added the following test to GenericCacheBackendUnitTest.php:
The test initially failed, then passed after the patch was applied, but I'm a little wary that I reverse engineered an outcome so more reviewers would be good.
Comment #2
olli CreditAttribution: olli commentedYour test looks good to me.
Comment #3
olli CreditAttribution: olli commentedOne small thing:
$backend->get('test2')
could pass the second parameter$backend->get('test2', TRUE)
.Comment #4
olli CreditAttribution: olli commentedHere's the test from #1.
Comment #7
olli CreditAttribution: olli commentedComment #8
BerdirTest looks good, but $unrelated is a bit a strange name, maybe renamed to $backend_a and $backend_b?
Tagging novice to update this.
Comment #9
rpayanmPlease review :)
Comment #10
BerdirYou renamed it in the existing testDeleteAll() method (now I see where that came from), but not in the new test method testRemoveBin() :)
Comment #11
rpayanmOn two more method! :D
Comment #12
BerdirGreat, looks good now.
Comment #13
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 87be19c and pushed to 8.0.x. Thanks!