The permission dropdown at admin/user/user now displays the description of permissions, rather than the permissions themselves, likely an obvious result of the description permissions patch.

CommentFileSizeAuthor
#2 user-perm-oops-226501-2.patch730 byteswebchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

Assigned: Unassigned » webchick
Priority: Normal » Critical

Eek. :(

webchick’s picture

Assigned: webchick » Unassigned
Priority: Critical » Normal
Status: Active » Needs review
FileSize
730 bytes

This should do it.

webchick’s picture

Assigned: Unassigned » webchick
Priority: Normal » Critical

Er. Why did that happen? :P

keith.smith’s picture

Assigned: webchick » Unassigned
Priority: Critical » Normal
Status: Needs review » Reviewed & tested by the community

Simple and to the point. I've tested this, and it works fine.

keith.smith’s picture

Priority: Normal » Critical
vladimir.dolgopolov’s picture

Here is the test for Simpletest module.
The patch #2 pass it.


class TestCase226501 extends DrupalTestCase {
  function get_info() {
    return array(
      'name' => t('[226501] Permission descriptions are used incorrectly at admin/user/user'),
      'desc' => t('The permission dropdown at admin/user/user now displays the description of permissions, rather than the permissions themselves, likely an obvious result of the description permissions patch.'),
      'group' => t('Drupal 7 Tests'),
    );
  }

  function testIssue() {
    // get the permission dropdown options
    $filters = user_filters();
    $permission_options = $filters['permission']['options'];

    // check
    foreach (module_list() as $module) {
      if ($permissions = module_invoke($module, 'perm')) {
        foreach ($permissions as $permission => $description) {
          $this->assertTrue(isset($permission_options["$module module"][$permission]), "Permission '$permission' exists");
        }
      }
    }
  }

}

webchick’s picture

Marked http://drupal.org/node/236091 as a dupe of this. Still applies.

Dries’s picture

Priority: Critical » Normal
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.