A minor point, but for clarity I suggest changing:

function node_configure() {
  // Only show rebuild button if there is 0 or more than 2 rows in node_access table,
  // or if there are modules that implement node_grant.
...

to

function node_configure() {
  // Only show rebuild button if there are 0 or 2 or more rows in {node_access}
  // table, or if there are modules that implement hook_node_grants().
...

Patch to follow.

CommentFileSizeAuthor
#1 permissions_button_226480_6.x.patch1.23 KBgpk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gpk’s picture

Status: Active » Needs review
FileSize
1.23 KB

Self explanatory I guess?! Patch for 6.x/7.x.

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community
Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

gpk’s picture

Version: 7.x-dev » 6.x-dev
Status: Fixed » Reviewed & tested by the community

Thanks Dries, now for 6.x..

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

I am probably not the best to ask with English punctuation, but having a comma after "more" seems inappropriate. Anyway, not to nitpick on this, I committed what went into Drupal 7 to Drupal 6 anyway.

gpk’s picture

Thanks Gábor.

Strictly speaking the comma after "0" could probably be omitted as well as the one after "more", but I think I was trying to avoid any possibility of confusion as to what the comment was saying!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.