Problem/Motivation

Drupal\config\Tests\ConfigImportAllTest creates a list of all modules using system_rebuild_module_data(), which creates a list of all modules -- not just core modules. However, the description of this test reads: 'Tests the largest configuration import possible with the modules and profiles provided by core.'

For more information about why this is a problem, see #2258247-7: Remove useless Drupal\config\Tests\ConfigImportAllTest.

Proposed resolution

Change the description to make it clear that all modules will be included.

Remaining tasks

Determine that the revised description is correct.

User interface changes

New test description.

API changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because documentation
Unfrozen changes Unfrozen because it only changes a docblock comment to be more accurate
CommentFileSizeAuthor
#4 config-import-description-2264755-4.patch547 bytesadci_contributor
#1 2264755-config-import-description-1.patch812 bytesmtift
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
FileSize
2264755-config-import-description-1.patch812 bytes

Patch attached

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Priority: Normal » Minor
Status: Needs review » Needs work
Issue tags: +Needs re-roll, +Documentation

This will need a re-roll after #697760: Replace getInfo() in tests with native phpDoc + annotations (following PHPUnit).

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Issue tags: -Needs re-roll +Needs reroll
adci_contributor’s picture

adci_contributor CreditAttribution: adci_contributor commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
config-import-description-2264755-4.patch547 bytes

Description fixed in the DocBlock

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Assigned: mtift » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good to me.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Issue summary: View changes

I added a beta phase evaluation to the issue summary.

  • catch committed 4a6fce7 on 8.0.x 
    Issue #2264755 by mtift, adci_contributor: Clarify description of Drupal...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.