Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Outline too should be reviewed to see that we aren't just eliminating visual cues. In general we shouldn't be using outline: 0; or outline: none;
More info from the handbook:
https://drupal.org/node/1638020
It's fine to have outline: 0;
in the skip links as that is only visible on focus so is very clear.
There may be other areas where it works just fine since the visual cue is provided in another way.
Comment | File | Size | Author |
---|---|---|---|
#1 | Bartik-outline-2263975-1.patch | 480 bytes | mgifford |
Comments
Comment #1
mgiffordComment #2
mgiffordI can't identify visual differences yet with this patch...
Comment #3
mgiffordComment #4
emma.mariaComment #5
dcrocks CreditAttribution: dcrocks commentedDon't you mean 'cue' instead of 'queue'?
Comment #6
mgifford@dcrocks - Yes. Just updated that. Got the wrong Q...
Comment #8
pp CreditAttribution: pp commentedI found an another outline: 0 in the style.css:
style.css:353: outline: 0;
Why didn't You delete it?
Comment #9
mgiffordIn my review of the that instance:
The focus behavior of the skip link presently is not a barrier to keyboard only users. It only shows up when it has focus, so the outline does not serve a need for accessibility.
Comment #10
pp CreditAttribution: pp commentedok, it sounds correct for me.
Comment #11
alexpottCommitted 383a916 and pushed to 8.0.x. Thanks!