Outline too should be reviewed to see that we aren't just eliminating visual cues. In general we shouldn't be using outline: 0; or outline: none;

More info from the handbook:
https://drupal.org/node/1638020

It's fine to have outline: 0; in the skip links as that is only visible on focus so is very clear.

There may be other areas where it works just fine since the visual cue is provided in another way.

CommentFileSizeAuthor
#1 Bartik-outline-2263975-1.patch480 bytesmgifford
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
FileSize
Bartik-outline-2263975-1.patch480 bytes
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Priority: Normal » Minor
Related issues: +#2250121: Check for proper use of CSS Outline in Seven

I can't identify visual differences yet with this patch...

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Active » Needs review
emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Issue tags: +frontend, +CSS
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented

Don't you mean 'cue' instead of 'queue'?

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Issue summary: View changes

@dcrocks - Yes. Just updated that. Got the wrong Q...

mgifford queued 1: Bartik-outline-2263975-1.patch for re-testing.

pp’s picture

pp CreditAttribution: pp commented
Status: Needs review » Needs work

I found an another outline: 0 in the style.css:

style.css:353: outline: 0;

Why didn't You delete it?

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

In my review of the that instance:

.skip-link:hover,
.skip-link:active,
.skip-link:focus {
  outline: 0;
}

The focus behavior of the skip link presently is not a barrier to keyboard only users. It only shows up when it has focus, so the outline does not serve a need for accessibility.

pp’s picture

pp CreditAttribution: pp commented
Status: Needs work » Reviewed & tested by the community

ok, it sounds correct for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 383a916 and pushed to 8.0.x. Thanks!

  • alexpott committed 383a916 on 8.0.x 
    Issue #2263975 by mgifford: Fixed Check for proper use of CSS Outline in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.