Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Message Group Filename Line Function Status
Bartik theme disabled during import. Other ConfigImportUITest.php 214 Drupal\config\Tests\ConfigImportUITest->testImport()
[08-May-2014 11:25:51 UTC] Uncaught PHP Exception InvalidArgumentException: "Unknown theme: bartik." at /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Extension/ThemeHandler.php line 282 Fatal error Unknown 0 Unknown
Occasionally ConfigImportUITest fails with the above errors.
Comment | File | Size | Author |
---|---|---|---|
#6 | 2263201.6.patch | 1.9 KB | alexpott |
#1 | random-config-ui-fail.will-fail.patch | 645 bytes | alexpott |
#1 | random-config-ui-fail.patch | 2.53 KB | alexpott |
Comments
Comment #1
alexpottMaybe we're using the list before it has been initialised. Let's make the code a bit safer.
Comment #2
alexpottThe patch includes work from #2226301: run-test.sh --repeat should work nicely with --concurrency to allow concurrent testing of the same test class.
Comment #5
alexpottComment #6
alexpottNow with just the patch
Comment #7
XanoThis seems a little out of scope, but it's not a bad change.
If nobody minds the scope creep, then this looks RTBC if the tests pass.
Comment #8
sun@Xano: That line is not changed by the patch? :-)
I'm tempted to RTBC, although I wondered whether this regression could be tested in some way... e.g., a single method in
ThemeHandlerTest
that invokes all methods without callinglistInfo()
upfront, whereas the result of the methods is irrelevant, just no unexpected error. Such a test should fail in HEAD, but not with this patch?Comment #9
tim.plunkettFor the record, this is technically correct, and works fine, but the change is a good one, we shouldn't be relying on $this->list directly.
Because...
It leads to this assumption, which caused the bug. $this->list can be not populated.
Great find @alexpott, thanks!
Comment #10
XanoI blame Dreditor...
Just for the record: I'm fine with fixing this everywhere in the theme handler, but I just wanted to point out that only the last hunk of the patch contains the fix and the rest is just a clean-up, but a good one.
Comment #11
Dries CreditAttribution: Dries commentedThis is a good change that makes the code more robust. Committed to 8.x. Thanks.