When overriding theme_pager and using 'ol' instead of 'li' as the list type views ajax pagination fails to apply to the pager elements.

This is due to ul.pager being specifically targetted in ajax_view.js.

Applied a patch that will also target ol.pager.

CommentFileSizeAuthor
#3 2261219-ajax-views-ol-pager-3.patch528 bytesaaron.ferris
#1 2261219-ajax-views-ol-pager.patch572 bytesaaron.ferris
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented
FileSize
2261219-ajax-views-ol-pager.patch572 bytes
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Version: 7.x-3.7 » 7.x-3.x-dev
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 5 year old patch to ajax_view.js does not apply to the latest views 7.x-3.x-dev.

Checking patch js/ajax_view.js...
error: while searching for:
 * Attach the ajax behavior to each link.
 */
Drupal.views.ajaxView.prototype.attachPagerAjax = function() {
  this.$view.find('ul.pager > li > a, th.views-field a, .attachment .views-summary a')
  .each(jQuery.proxy(this.attachPagerLinkAjax, this));
};

error: patch failed: js/ajax_view.js:85
error: js/ajax_view.js: patch does not apply
aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented
FileSize
2261219-ajax-views-ol-pager-3.patch528 bytes

Attaching a patch that should apply cleanly to 7.x-3.x-dev

aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented
Status: Needs work » Needs review
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Thanks Aaron, applied cleanly and works for me.

aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented

Welcome!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #3054023: Plan for Views 7.x-3.24 release

Committed. Thanks,

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.