D6->D8 Profile field (checkbox)

I worked on this for a bit this afternoon, made some progress, but not a total success yet.

I was able to set the field type to "list_boolean" and the form widget to "Single on/off checkbox", but to finish the job, I think the "display_label" setting for the "Single on/off checkbox" needs to be set to true (it defaults to false).

I've attached a patch with what I've done so far (including modifying the MigrateUserProfileEntityFormDisplayTest.php to check for the proper field type and display_label value), but would gladly accept some guidance on setting the display_label properly (it is set to false by default, but should be set to true otherwise the checkboxes don't have any labels). I messed around with adding a static map to the d6_user_profile_entity_form_display.yml that would default to "constants.empty" for everything except @type=options_onoff, but couldn't make it work.

Thanks,
-mike

I chatted with benjy this morning on IRC and he gave me a couple of ways to attack the display_label stuff:

If this is only an issue with profile field checkboxes, then we should be able to fix it in the d6_user_profile_entity_form_display.yml with something like:

  'options.settings':
    plugin: field_instance_widget_settings
    source:
      - @type
      - constants.empty # we don't have any settings.
  'options.settings.display_label':  # use this if D6 CCK checkboxes work fine, otherwise do it in FieldInstanceWidgetSettings()->getSettings()
    plugin: static_map
    default_value: false
    source: type
    map:
      checkbox: true

If this is also an issue with D6 CCK checkboxes, then a more general solution can be done in FieldInstanceWidgetSettings()->getSettings(). We can pass the source $row in and set the display label based on the source type.

I'll work on this later today.

Thanks,
-mike

After working on this a bit more, I went ahead and spun off the CCK Single on/off checkbox stuff into a different issue (https://drupal.org/node/2262275), as they're really a bit of a different beast. When using the CCK Single on/off checkbox widget, the fieldtype can be a decimal, float, integer, or text, so there's going to have to be some CCK-specific logic that doesn't really apply to profile fields.

Profile checkboxes are always integers (0 or 1), so this patch only takes care of them. I tested this patch by running:

1. MigrateDrupal6Test
2. MigrateUserProfileEntityFormDisplayTest
3. MigrateUserProfileFieldInstanceTest
4. MigrateUserProfileFieldTest
5. A manual test of a real-ish D6 database with several profile checkbox fields.

Thanks,
-mike

Ah - I missed some test setup() stuff in:

1. MigrateUserProfileEntityDisplayTest
2. MigrateProfileValuesTest

Let's try this again...

Thanks,
-mike

Added a comment per benjy's request.

Updated patch attached.

Thanks,
-mike

9: 2260239-9.patch queued for re-testing.

I don't understand - all I did was add a comment - is this a testbot fail?

I just regenerated the patch along with an interdiff...

Thanks,
-mike