Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.
Problem/Motivation
The FormBuilderTest is testing both the FormBuilder class and the OptGroup class. Ideally unit tests should cover only one class.
Proposed resolution
Create a new unit test for OptGroup
Remaining tasks
- Write patch (novice)
- Review patch to check it fixes the issue, the change is properly documented and for coding standards. Provide test evidence (novice)
- Keep issue summary up to date (novice)
User interface changes
None
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff-1-3.txt | 375 bytes | martin107 |
#3 | optGroup-2259301-3.patch | 3 KB | martin107 |
#1 | optGroup-2259301-1.patch | 3.03 KB | martin107 |
Comments
Comment #1
martin107 CreditAttribution: martin107 commentedThanks @alexpott - a useful learning experience.
FormBuilderTest and OptGroupTest pass on my machine..
Comment #2
alexpottNeeds a need line at the EOF
Comment #3
martin107 CreditAttribution: martin107 commentedFixed.
Comment #4
alexpottRan test locally
Looks good to go. Thanks.
Comment #5
webchickCommitted and pushed to 8.x. Thanks!