Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
the namespace and naming is not consistent with rest of the core
Comment | File | Size | Author |
---|---|---|---|
#16 | move-2258335-16.patch | 1.32 KB | mitrpaka |
#11 | 2258335-11.patch | 9.25 KB | rpayanm |
#9 | 2258335-interdiff.txt | 1.71 KB | rpayanm |
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedComment #2
daffie CreditAttribution: daffie commentedThis still needs to happen, But it needs a reroll.
Comment #3
rpayanmComment #4
tibbsa CreditAttribution: tibbsa commentedShouldn't the file-level comment be 'Contains \Drupal\Tests\Component\Uility\ImageTest' rather than '...\Image\ImageTest'?
Comment #5
rpayanm@tibbsa yeah! you are right, thank you!
Comment #6
daffie CreditAttribution: daffie commentedSome docblock changes to get in line with other PHPUnit tests.
Comment #7
daffie CreditAttribution: daffie commentedDid some digging and I believe it is better to change the comments to:
Comment #8
rpayanmComment #9
rpayanmComment #10
daffie CreditAttribution: daffie commented@rpayanm: I think something went wrong with your patch. There is all sort of stuff that does not belong in this patch.
Comment #11
rpayanmSorry, I forgot
git rebase 8.0.x
after ofgit pull
.Comment #12
daffie CreditAttribution: daffie commentedThe ImageTest has been moved and renamed.
The old test file has been deleted.
The comments are all in order.
It looks good to me so I give it a RTBC.
Comment #13
tstoecklerNot downgrading but in these cases it really helps to roll patches with
-C -M
in order to allow for easier reviewing.Comment #14
rpayanm@tstoeckler you can explain more about this? it's good learn every something new!
Comment #15
alexpottThis does more than just move.
We should have one issue to move and one issue to fix other issues.
@rpayanm read https://www.drupal.org/documentation/git/configure - specifically the bit on Optimize diffs for renamed and copied files
Comment #16
mitrpaka CreditAttribution: mitrpaka commentedComment #17
daffie CreditAttribution: daffie commentedThe ImageTest has been moved and renamed.
The old test file has been deleted.
This patch has been made with the "git mv" command.
It looks good to me so I give it a RTBC.
Comment #18
alexpottTests are not covered by the beta evaluation. Committed 2c23066 and pushed to 8.0.x. Thanks!