This is a minor label change in maintainers.txt after the rename of 'Edit' to 'Quick edit' module.

CommentFileSizeAuthor
#3 edit-to-quickedit-in-maintainers-2257319-2.patch1.25 KBjessebeach
edit-to-quickedit-in-maintainers.patch1.22 KBjessebeach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Hah, good catch! :)

+++ b/core/MAINTAINERS.txt
@@ -353,6 +349,10 @@ Path module
+Quick edit module

s/Quick edit/Quick Edit/? That's the module's name in its .info.yml file.

P.S.: when/how do we rename the component on d.o?

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Issue tags: +Spark
FileSize
edit-to-quickedit-in-maintainers-2.patch846 bytes
jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Assigned: Wim Leers » webchick
Status: Active » Reviewed & tested by the community
FileSize
edit-to-quickedit-in-maintainers-2257319-2.patch1.25 KB

You totes beat me to to that update :)

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Reviewed & tested by the community » Needs review
jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Needs review » Reviewed & tested by the community

If the bot doesn't come back green, I'll eat my shoe.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: edit-to-quickedit-in-maintainers-2257319-2.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review

3: edit-to-quickedit-in-maintainers-2257319-2.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

@jessebeach I recommend putting some sriracha on that shoe. :)

Opened #2257539: Random fail: InvalidArgumentException: "Unknown theme: bartik." in Drupal\config\Tests\ConfigImportUITest for the random fail

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x.

  • Commit 7d6779b on 8.x by webchick: 
    Issue #2257319 by jessebeach: Change 'Edit' to 'Quick edit' in...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Component: edit.module » quickedit.module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.