Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Similar to #950534: [policy] Consistently use "email" instead of "e-mail" in Drupal. Let's standardize on "website" instead of "web site"
We use both, but would be good to just keep to the one that AP has been using since 2010 it seems.
Comment | File | Size | Author |
---|---|---|---|
#22 | interdiff_17-22.txt | 4.32 KB | pradeepjha |
#22 | 2256367-22.patch | 17.25 KB | pradeepjha |
#20 | interdiff_17-20.txt | 4.49 KB | pradeepjha |
#20 | 2256367-20.patch | 16.97 KB | pradeepjha |
#18 | Screenshot 2020-06-02 at 3.31.33 PM.png | 230.96 KB | Rkumar |
Comments
Comment #1
mgiffordComment #2
mgiffordComment #3
tvn CreditAttribution: tvn at Drupal Association commentedComment #4
jhodgdonThe policy is clear:
https://www.drupal.org/drupalorg/style-guide/content#relatedwords
At least for drupal.org, our policy is to use "website".
So converting this into a meta issue. I suggest making two patches, on two separate issues:
a) Fix up any UI text (including help text) that violates the policy. This one can only go into the 8.1 and 8.2 branches (and only for 8.1 if it happens before the first release candidate, because after that UI text is frozen except for huge bugs, and this isn't a huge bug).
b) Fix up any API docs and comments that violate the policy. This one can be committed to all 8.x branches.
I haven't checked to see if both types of problem exist (UI text and API docs)... if there aren't both, then this can be just one patch on this issue.
Comment #5
jhodgdonOh, sorry, just noticed this patch. It seems to be all UI text.
However, I did a grep and there are also API docs and comments with this problem. So yes, please do make two child issues as noted in comment #4. Thanks!
Comment #13
pradeepjha CreditAttribution: pradeepjha commentedI'll be working on this.
Comment #14
pradeepjha CreditAttribution: pradeepjha commentedHi @jhodgdon
I have searched the 'web site' text in core folder, found in multiple places. I've added those changes in patch. Please have a look.
Comment #15
pradeepjha CreditAttribution: pradeepjha commentedComment #16
longwaveWe shouldn't change anything in
core/assets/vendor
, this is third party code that belongs to CKEditor.Comment #17
cburschkaEdit: This patch seems to cleanly apply to 9.1.x as well.
Comment #18
Rkumar CreditAttribution: Rkumar as a volunteer and at Srijan | A Material+ Company commentedAfter applying the patch still can see some occurrences.
To maintain the uniformity, it would be great if we can replace the below occurrence as well.
Comment #19
Rkumar CreditAttribution: Rkumar as a volunteer and at Srijan | A Material+ Company commentedA correction, I checked it for D9.
Having said that we need this update for D9 as well to fix for all the occurrences.
Comment #20
pradeepjha CreditAttribution: pradeepjha commentedThanks @Rkumar. I've make changes for D9 as well. Please check my latest patch.
Comment #21
pradeepjha CreditAttribution: pradeepjha commentedThere minor correction I need to do with my last patch.
Comment #22
pradeepjha CreditAttribution: pradeepjha commentedComment #23
Rkumar CreditAttribution: Rkumar as a volunteer and at Srijan | A Material+ Company commentedNow it seems fine. No any occurrence of web sites.
Comment #24
Rkumar CreditAttribution: Rkumar as a volunteer and at Srijan | A Material+ Company commentedComment #25
xjmNice work on this issue. It doesn't appear to be a meta.
I considered whether we could use core's new spellchecking to disallow "web site", but I tested it and it doesn't seem to be possible to restrict phrases, only words.
Comment #27
xjmCommitted to 9.1.x. Thanks! Since this includes string changes, it should not be backported to a previous version.
Comment #28
xjmI forgot to mention, @Rkumar, posting screenshots of your codebase or CLI does not advance the issue, since the automated testing infrastructure tells us whether the patch applies correctly. It's better to described what you reviewed and how -- not with screenshots, but by pasting the commands you used, the results, etc. and describing why you think the review you did is sufficient to mark the issue RTBC.