CommentFileSizeAuthor
#3 testperf.taxonomy-legacy.patch2.04 KBsun
#2 testperf.taxonomy-legacy.patch2.42 KBsun
testperf.taxonomy-LegacyTest.patch2.25 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, testperf.taxonomy-LegacyTest.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
testperf.taxonomy-legacy.patch2.42 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
FileSize
testperf.taxonomy-legacy.patch2.04 KB

Now without the run-tests.sh performance optimization. This one is ready.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Related issues: +#913086: Allow modules to provide default configuration for running tests

FWIW, those ~40 lines of boilerplate code just to add a "Tags" field to a node type are really cumbersome... That's why I started to look into #913086: Allow modules to provide default configuration for running tests again + proposed a completely new solution for creating test fixtures over there.

Shouldn't hold up this patch though.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Awesome.

  • Commit 749f7ea on 8.x by catch: 
    Issue #2254211 by sun: Fix test performance of Drupal\taxonomy\Tests\...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.