Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
In a Guzzle issue on github mtdowling asked why Guzzle is not mentioned in the default user agent header in our implementation of the HTTP client. This is a good question, it would be more accurate to include both Drupal and Guzzle I think?
Proposed resolution
Add the default user agent string to our Drupal string.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#4 | 2251829-4.patch | 542 bytes | damiankloip |
#1 | 2251829.patch | 516 bytes | damiankloip |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedComment #2
damiankloip CreditAttribution: damiankloip commentedComment #3
sunUnless I'm mistaken, there is a formal standard syntax for specifying multiple vendors (and optionally versions) in a User-Agent HTTP header — are you sure that a simple space is correct?
FWIW, the drupal.org URL should use HTTPS... ;) Do we want to fix that here in one go? :-)
Comment #4
damiankloip CreditAttribution: damiankloip commentedWe spoke about this on IRC, separating by a space is totally fine. We should prob add the version number too though.
Example header string with this patch:
Drupal/8.0-dev (+https://drupal.org/) Guzzle/4.0.0 curl/7.30.0 PHP/5.5.11
Not doing an interdiff for a one line patch :)
Comment #5
sunThanks!
Comment #6
webchickCommitted and pushed to 8.x. Thanks!
Comment #8
damiankloip CreditAttribution: damiankloip commentedNice, real User agent headers - thanks!