As @webchick said back in 2009 - #134359-17: Warn users about contrast problems when using the color module :

Furthermore, several of our default colour schemes for Color module break this spec. Core should not be generating errors out of the box, so this would need to be fixed as well.

I think it makes sense to separate this issue off from the main one and just fix the colors.

I think the outstanding problems are:

Firehouse:
Header background bottom: #cf3535 -> #d64e4e
Text color: #3b3b3b -> #888888

Ice:
Link color: #019dbf -> #016b83

There might be others, but let's just get this patched up for the Color module separately from the warning message.

CommentFileSizeAuthor
#8 set_proper_contrast_on-2248405-8.patch928 bytesdavidhernandez
#2 ice.png141.39 KBmgifford
#2 firehouse.png149.25 KBmgifford
#1 color-contrast-choices-firehouse-ice-1.patch865 bytesmgifford
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Active » Needs review
Issue tags: +Accessibility, +color contrast
FileSize
color-contrast-choices-firehouse-ice-1.patch865 bytes

Some color contrast tools don't deal with rgba & opacity all that well. This one does:
http://leaverou.github.io/contrast-ratio/#rgba%28255%2C255%2C255%2C.8%29...

This patch should address the outstanding issues with these themes.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
FileSize
firehouse.png149.25 KB
ice.png141.39 KB

Firehouse theme with color adjustments

Ice theme with color adjustments

Status: Needs review » Needs work

The last submitted patch, 1: color-contrast-choices-firehouse-ice-1.patch, failed testing.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented

1: color-contrast-choices-firehouse-ice-1.patch queued for re-testing.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented
Status: Needs work » Reviewed & tested by the community

A small patch but a necessary one. Seems RTBC with the patch in #1 now passing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: color-contrast-choices-firehouse-ice-1.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

1: color-contrast-choices-firehouse-ice-1.patch queued for re-testing.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez commented
Status: Needs work » Needs review
FileSize
set_proper_contrast_on-2248405-8.patch928 bytes

The Ice CSS change moved a few lines.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed f309e65 and pushed to 8.x. Thanks!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Zero screenshots to show that you completely changed Bartik's blue? That's a relatively huge change, and really deserved more discussion.

EDIT: I see I was looking at the wrong commit, it was #2125621: Contrast between title/slogan and header is too low

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.