I noticed that Drupal module OpenID doesn't recognize openid.pl domain

CommentFileSizeAuthor
#8 224793.patch2.43 KBrobloach

Comments

robloach’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Status: Active » Postponed (maintainer needs more info)

OpenID URL implements both OpenID 1 and 2 specs, so I'm not sure what's wrong. In the very least, try updating to a later version of the module.

robloach’s picture

Could you try it again? I just put in a patch that switches the attributes around... http://drupal.org/node/229877

robloach’s picture

Title: openid.pl domain isn't supported » Split up openid and openid2 links

Some hosts, like sourceforge, don't support having the two links listed in the same variable, so we should split them up.

<link rel="openid.server" href="http://pip.verisignlabs.com/server" />
<link rel="openid.delegate" href="http://username.pip.verisignlabs.com/" />
<link rel="openid2.provider" href="http://pip.verisignlabs.com/server" />
<link rel="openid2.local_id" href="http://username.pip.verisignlabs.com/" />
Inte’s picture

I use phpMyID which only supports OpenID 1.1 (AFAIK) and run into some problems.

Removing openid2.provider and openid2.local_id in /sites/all/modules/openidurl/openidurl.module solved it for me.

Maybe you can add a selection, which OpenID-HTML-Headers get included.

For example:

Include following HTML-Headers (make sure which standard your provider supports):
[X] OpenID 1.0
[X] OpenID 1.1
[ ] OpenID 2.0
robloach’s picture

Great idea, Inte.

robloach’s picture

Assigned: Unassigned » robloach

I'll hit it up today. Mind testing 6.x-1.x-dev once it's in? I'd like to do a release sooner then later.

robloach’s picture

Actually, could you test this with 6.x-1.x-dev now? It already splits the parameters into two different link tags instead of sticking them in the same parameter.....

    drupal_set_html_head('<link rel="openid.server" href="'. check_url($server) .'" />');
    drupal_set_html_head('<link rel="openid.delegate" href="'. check_url($delegate) .'" />');
    drupal_set_html_head('<link rel="openid2.provider" href="'. check_url($server) .'" />');
    drupal_set_html_head('<link rel="openid2.local_id" href="'. check_url($delegate) .'" />');

If that works for you, I'll make a release.....

robloach’s picture

StatusFileSize
new2.43 KB

............ Dev should be good..... If not, this'll do it.

robloach’s picture

Status: Postponed (maintainer needs more info) » Fixed

After some testing on SourceForge, it still seems to be a problem, so I committed this.

http://drupal.org/cvs?commit=139652

robloach’s picture

Version: 6.x-1.x-dev » 5.x-1.x-dev
Status: Fixed » Patch (to be ported)

If anyone wants this in the Drupal 5 branch, feel free to send in a patch.

Inte’s picture

I checked the OpenID 1.1 settings as phpMyID doesn't support OpenID 2.0

It does it's job ... nothing more and nothing less. ;) Thanks for your work.

Maybe someone with a 1.1 & 2.0 compatible provider should run a check including both parameters, before you release a stable version (which I'm waiting for).

robloach’s picture

Assigned: robloach » Unassigned

  • RobLoach committed 495a5df on 8.x-1.x
    #224793: Split up OpenID version compatibility.
    
    
ao2’s picture

Issue summary: View changes
Status: Patch (to be ported) » Fixed

The issue has been fixed for quite some time, let's update the status to reflect that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.