While reviewing tests I found that TableSortExtenderUnitTest.php has the following docblock at the top:

/**
 * Tests unicode handling features implemented in unicode.inc.
 */
class TableSortExtenderUnitTest extends UnitTestBase {
CommentFileSizeAuthor
#1 2245989-1-drupal-tablesort_wrong_class_docblock.patch643 bytesjuampynr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juampynr’s picture

juampynr CreditAttribution: juampynr commented
FileSize
2245989-1-drupal-tablesort_wrong_class_docblock.patch643 bytes

Here is a patch that includes the right text.

juampynr’s picture

juampynr CreditAttribution: juampynr commented
Status: Active » Needs review

Setting to Needs review.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Component: phpunit » simpletest.module
Status: Needs review » Reviewed & tested by the community

+1

Note, this is not a phpunit test.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2245989-1-drupal-tablesort_wrong_class_docblock.patch, failed testing.

juampynr’s picture

juampynr CreditAttribution: juampynr commented
Status: Needs work » Reviewed & tested by the community

This is just a documentation change. Tests failed for an external reason.

Setting it back to RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Wow, breaking testbot with a docs patch. Impressive. ;)

Committed and pushed to 8.x. Thanks!

  • Commit c16288d on 8.x by webchick: 
    Issue #2245989 by juampy: Wrong class docblock in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.