Problem/Motivation

We've embraced usage of @covers in unit tests, which is great.
Unfortunately, the bot does not run tests with that flag (because it is slower), which has allowed invalid usages to creep into core.

Proposed resolution

Fix the invalid usages.

Remaining tasks

Consider opening a testbot feature request to run tests with coverage reports on a regular interval

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#1 phpunit-covers-2245185-1.patch1.27 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
phpunit-covers-2245185-1.patch1.27 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

If you can read, things are better usually.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue tags: +Quick fix
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit d4ff24a on 8.x by webchick: 
    Issue #2245185 by tim.plunkett: Fix invalid @covers usage.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.