Problem/Motivation

In #2222719: Use parameter matching via reflection for access checks instead of pulling variables from request attributes, I was switching some of the access checks away from services, and _node_revision_access() broke (because I didn't notice it).

Proposed resolution

It just wraps a method, is only called from tests, and is prefixed with an underscore. Let's kill it.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
_node_revision_access.patch5.33 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
CreditAttribution: saltednut commented
Status: Needs review » Reviewed & tested by the community

Pretty straight forward. Really no good reason for this proxy to exist.

Node revision permissions test passes locally.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 7f273d2 and pushed to 8.x. Thanks!

  • Commit 7f273d2 on 8.x by alexpott: 
    Issue #2239307 by tim.plunkett: Remove obsolete _node_revision_access.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.