Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bookmarvel’s picture

Status: Needs review » Needs work

i looked at the patch and i read each line. the 3 changes are correct
#1642062: Add TempStore for persistent, limited-term storage of non-cache data introduced 4 misspellings
grep -R KeyValueStoreEx core | grep -v KeyValueStoreExpirableInterface

needs work to fix the 4th one

jhodgdon’s picture

Issue tags: +Novice
bookmarvel’s picture

Assigned: Unassigned » bookmarvel

im going to do this right now

bookmarvel’s picture

Assigned: bookmarvel » Unassigned
Status: Needs work » Needs review
FileSize
713 bytes
1.98 KB

i corrected the 4th misspelling in the file

filijonka’s picture

Hi

according to the doxygen that a inheritdoc should be use when implementing a method from a interface which is the case here. See inheritdoc

filijonka’s picture

Status: Needs review » Needs work
jhodgdon’s picture

RE #5 - yes please!

visabhishek’s picture

Status: Needs work » Needs review
FileSize
822 bytes
1.83 KB

updated patch

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, that looks right to me!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit a3bb804 on 8.x by catch:
    Issue #2238649 by visabhishek, bookmarvel, chx: Expirable key value...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.