Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#8 | KeyValueStoreExpirableInterface-8.patch | 1.83 KB | visabhishek |
#8 | interdiff-2238649-4-8.txt | 822 bytes | visabhishek |
#4 | KeyValueStoreExpirableInterface-4.patch | 1.98 KB | bookmarvel |
#4 | interdiff-2238649-0-4.txt | 713 bytes | bookmarvel |
KeyValueStoreExpirableInterface.patch | 1.59 KB | chx | |
Comments
Comment #1
bookmarvel CreditAttribution: bookmarvel commentedi looked at the patch and i read each line. the 3 changes are correct
#1642062: Add TempStore for persistent, limited-term storage of non-cache data introduced 4 misspellings
grep -R KeyValueStoreEx core | grep -v KeyValueStoreExpirableInterface
needs work to fix the 4th one
Comment #2
jhodgdonComment #3
bookmarvel CreditAttribution: bookmarvel commentedim going to do this right now
Comment #4
bookmarvel CreditAttribution: bookmarvel commentedi corrected the 4th misspelling in the file
Comment #5
filijonka CreditAttribution: filijonka commentedHi
according to the doxygen that a inheritdoc should be use when implementing a method from a interface which is the case here. See inheritdoc
Comment #6
filijonka CreditAttribution: filijonka commentedComment #7
jhodgdonRE #5 - yes please!
Comment #8
visabhishek CreditAttribution: visabhishek commentedupdated patch
Comment #9
jhodgdonThanks, that looks right to me!
Comment #10
catchCommitted/pushed to 8.x, thanks!