#2218655: Core expects $theme.settings default config file to exist moves the schema from system.schema.yml to core.data_types.schema.yml, but doesn't change the contents. The contents, however, has the label "Shortcut icon settings" 3 times: for favicon, features, and logo. That's the correct label for the first one, but not for the other two.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

effulgentsia’s picture

Issue tags: +Novice
sriharsha.uppuluri’s picture

Assigned: Unassigned » sriharsha.uppuluri
Status: Active » Needs review
FileSize
694 bytes
12.32 KB

I have renamed the label of
features - Features icon settings,
logo - Logo settings

sun’s picture

Status: Needs review » Needs work

The parent issue has landed, so we just need the config schema label adjustments here now :-)

sriharsha.uppuluri’s picture

Assigned: sriharsha.uppuluri » Unassigned
cs_shadow’s picture

Status: Needs work » Needs review
FileSize
759 bytes

Attaching patch that just changes config labels.

sun’s picture

+++ b/core/config/schema/core.data_types.schema.yml
@@ -122,7 +122,7 @@ theme_settings:
-      label: 'Shortcut icon settings'
+      label: 'Features icon settings'

Just "Feature settings" (no icon involved)

Or "Optional features" ? (AFAIK, all of them are boolean on/off checkbox toggles only)

cs_shadow’s picture

Attaching patch where its renamed to "Optional Features".

Status: Needs review » Needs work

The last submitted patch, 7: drupal-theme_setting_labels_dup-2236089-7.patch, failed testing.

cs_shadow’s picture

Status: Needs work » Needs review
FileSize
754 bytes

Attaching the correct path mentioned in #8.

cs_shadow’s picture

Changed to follow sentence-casing.

The last submitted patch, 9: drupal-theme_setting_labels_dup-2236089-9.patch, failed testing.

sun’s picture

Status: Needs review » Reviewed & tested by the community

Thanks! :-)

  • Commit 2aacece on 8.x by catch:
    Issue #2236089 by cs_shadow, sriharsha.uppuluri: theme_settings schema...
star-szr’s picture

Status: Reviewed & tested by the community » Fixed

Just missing this:

Committed/pushed to 8.x, thanks!

:)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.