Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
#2218655: Core expects $theme.settings default config file to exist moves the schema from system.schema.yml to core.data_types.schema.yml, but doesn't change the contents. The contents, however, has the label "Shortcut icon settings" 3 times: for favicon
, features
, and logo
. That's the correct label for the first one, but not for the other two.
Comment | File | Size | Author |
---|---|---|---|
#10 | drupal-theme_setting_labels_dup-2236089-10.patch | 754 bytes | cs_shadow |
#9 | drupal-theme_setting_labels_dup-2236089-9.patch | 754 bytes | cs_shadow |
#7 | drupal-theme_setting_labels_dup-2236089-7.patch | 759 bytes | cs_shadow |
#5 | drupal-theme_setting_labels_dup-2236089-4.patch | 759 bytes | cs_shadow |
#2 | theme.settings.02.patch | 12.32 KB | sriharsha.uppuluri |
Comments
Comment #1
effulgentsia CreditAttribution: effulgentsia commentedComment #2
sriharsha.uppuluri CreditAttribution: sriharsha.uppuluri commentedI have renamed the label of
features - Features icon settings,
logo - Logo settings
Comment #3
sunThe parent issue has landed, so we just need the config schema label adjustments here now :-)
Comment #4
sriharsha.uppuluri CreditAttribution: sriharsha.uppuluri commentedComment #5
cs_shadow CreditAttribution: cs_shadow commentedAttaching patch that just changes config labels.
Comment #6
sunJust "Feature settings" (no icon involved)
Or "Optional features" ? (AFAIK, all of them are boolean on/off checkbox toggles only)
Comment #7
cs_shadow CreditAttribution: cs_shadow commentedAttaching patch where its renamed to "Optional Features".
Comment #9
cs_shadow CreditAttribution: cs_shadow commentedAttaching the correct path mentioned in #8.
Comment #10
cs_shadow CreditAttribution: cs_shadow commentedChanged to follow sentence-casing.
Comment #12
sunThanks! :-)
Comment #14
star-szrJust missing this:
:)