The following pages don't have primary buttons:

  • admin/config/people/accounts/fields
  • admin/config/people/accounts/form-display
  • admin/config/people/accounts/display
  • admin/config/people/accounts/display/compact
  • admin/config/people/accounts/display/full
CommentFileSizeAuthor
#5 2229157-primary-button5.png96.1 KBtompagabor
#4 2229157-primary_button_types_account_forms-4.patch1.93 KBchrisfromredfin
#3 2229157-more-button1.png64.96 KBtompagabor
#2 2229157-primary_button_types_account_forms-2.patch1.51 KBchrisfromredfin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Parent issue: » #2166473: [meta] Ensure correct button types are used on all pages
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
CreditAttribution: chrisfromredfin commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2229157-primary_button_types_account_forms-2.patch1.51 KB

This is actually a fix in the field_ui base classes so this might have larger-scale implications (in a good way).

tompagabor’s picture

tompagabor CreditAttribution: tompagabor commented
Status: Needs review » Needs work
FileSize
2229157-more-button1.png64.96 KB

Tested, and it works on these URL-s too:
admin/config/people/accounts/display/compact
admin/config/people/accounts/display/full

Suggestions:
1 - remove whitespace:
2229157-primary_button_types_account_forms-2.patch:12: trailing whitespace.
'#button_type' => 'primary',
2229157-primary_button_types_account_forms-2.patch:28: trailing whitespace.
'#type' => 'submit',

2 - We can add primary class to the ajax forms on the manage display pages. I atttach a screenshot about it:
Need primary button on the ajax form

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
CreditAttribution: chrisfromredfin commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
2229157-primary_button_types_account_forms-4.patch1.93 KB

Sure! Fixed the trailing whitespace and added support for the field settings on manage display in the base class. Also updated issue summary.

tompagabor’s picture

tompagabor CreditAttribution: tompagabor commented
FileSize
2229157-primary-button5.png96.1 KB

Looks good!
Please test one more person, and if everything is OK, then go RTBC.

tompagabor’s picture

tompagabor CreditAttribution: tompagabor commented

4: 2229157-primary_button_types_account_forms-4.patch queued for re-testing.

tompagabor’s picture

tompagabor CreditAttribution: tompagabor commented
Status: Needs review » Reviewed & tested by the community

I tested it again.
Everything is working.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Very nice! :)

Committed and pushed to 8.x. Thanks!

  • Commit bd4b9ae on 8.x by webchick: 
    Issue #2229157 by cwells, LewisNyman, tompagabor: Add correct button...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.