Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Sub-Issue of #1976158: Rename entity storage/list/form/render "controllers" to handlers.
Rename Drupal\content_translation\ContentTranslationController
(not the other one in the Controller namespace!) to ContentTranslationHandler.
Then to do the same for all subclasses of this for Node, Term and so on.
This class is referenced in the entity annotations, so make sure to do a text search for the class name so that you find those references as well.
Comment | File | Size | Author |
---|---|---|---|
#16 | 2227973-16.content_translation.controller_rename.patch | 27.63 KB | Berdir |
Comments
Comment #1
BerdirComment #2
pfrenssenComment #3
pfrenssenRenamed the classes. I grepped the codebase and it looks like all instances are covered, but I might have missed something. Let's see what the bot thinks of it.
Comment #4
BerdirLooks like the patch didn't pick up the renames, make sure to use -M or see https://drupal.org/documentation/git/configure about renames.
Comment #5
pfrenssenDidn't know about that option, this is much easier to review! Only CommentTranslationHandler was not picked up, the file is so small that it probably exceeded a threshold for LoC changed to still be recognized as a rename.
Comment #6
pfrenssenComment #7
BerdirWhen touching those, let's convert to {@inheritdoc}.
Same here, fix those by using Contains \Drupal... instead (note leading backslash)
Comment #8
pfrenssenI'll take care of it.
Comment #9
pfrenssenComment #10
BerdirStill a few left in this file. Just the Implements, the Form validation/submission references are fine.
Comment #11
pfrenssenFixed those too.
Comment #12
plachI completely agree with this rename (it matches how this stuff is called in D7 :) and the patch looks good!
Comment #14
Berdirgit rebase took care of the re-roll, so back to RTBC.
Comment #15
alexpott2227973-11.content_translation.controller_rename.patch no longer applies.
Comment #16
BerdirYeah, I failed to upload the re-roll it seems. Automatically done with git rebase, so back to RTBC.
Comment #17
alexpottCommitted 3b3ba27 and pushed to 8.x. Thanks!
Comment #19
alexpott