Slightly ugly error message if a module is incompatible with the version of core and the PHP version

Tweaks to the issue summary and issue title.

This looks good and I think #3 and #4 are a separate matter, please feel free to open another issue (after searching) to address that. The same thought crossed my mind :)

This needs some minor documentation cleanup then I think it's good to go.

+++ b/core/modules/system/lib/Drupal/system/Form/ModulesListForm.php
@@ -262,12 +262,14 @@ protected function buildRow(array $modules, Extension $module, $distribution) {
+    //Initialize an empty array of reasons why the module is incompatible. Add each reason as a seaprate element of the array.
+    $reasons = array();

This comment doesn't meet coding and documentation standards. See https://drupal.org/node/1354#drupal.

1) Missing a space after the "//".
2) Comment is over 80 characters, so please wrap.
3) "separate" is misspelled.

Thanks @cs_shadow! Attaching before and after screenshots to clearly show the difference.

Before:

After:

And please post back here when you create the other issue, I'd love to help with that.

Indeed it does affect 7.x:

diff --git a/modules/forum/forum.info b/modules/forum/forum.info
index b18a0e5..26dcbe4 100644
--- a/modules/forum/forum.info
+++ b/modules/forum/forum.info
@@ -4,7 +4,8 @@ dependencies[] = taxonomy
 dependencies[] = comment
 package = Core
 version = VERSION
-core = 7.x
+core = 8.x
+php = 5.6
 files[] = forum.test
 configure = admin/structure/forum
 stylesheets[all][] = forum.css

Nice, thanks @cs_shadow!

+++ b/modules/system/system.admin.inc
@@ -995,22 +995,27 @@ function _system_modules_build_row($info, $extra) {
+  // Initialize an empty array of reasons why the module is incompatible. Add
+  // each reason as a separate element of the array.
+  $reasons_short = array();
+  $reasons_long = array();

The only thing is there are now two arrays so "an empty array" makes less sense. "two empty arrays" might work, or something that explains that there are short and long descriptions. Just mind the 80 character wrap :)

Thanks, those docs look better! The early break is a bit unusual I think but can be fixed on commit IMO if someone objects :)

And here's the missing "after" screenshot:

17: core-fix_ugly_error_messages_when_incompatible_verison_for_d7-2227687-17.patch queued for re-testing.