Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment #N
Problem/Motivation
We don't have any cache tags for views plugins and handlers. The definition caches.
Proposed resolution
Add them!
Remaining tasks
Decide on which tags we want to add. extension? plugin type?
User interface changes
None
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#14 | 2226613-14.patch | 6.34 KB | damiankloip |
#8 | interdiff-2226613-8.txt | 4.69 KB | damiankloip |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedMaybe just KISS, like this?
Comment #2
dawehnerWhy would ever someone invalidate extension => 'views'?
Comment #3
damiankloip CreditAttribution: damiankloip commentedviews_invalidate_cache() in the future?
Comment #4
dawehnerOh I see
Comment #5
damiankloip CreditAttribution: damiankloip commentedComment #6
Wim LeersThis is in line with what
LibraryDiscovery
does:RTBC +1
Comment #7
dawehnerOn the longrun we probably want to store all of that information in one cache entry , but this is work for another issue. You need all of them anyway.
Comment #8
damiankloip CreditAttribution: damiankloip commentedCan we slightly extend this issue as it is teeny anyway? :) We need tags on views data too, we also might as well implement these for a couple of things.
And yes, we ideally do want to consolidate plugins into a single cache entry. I have been speaking to msonnabaum about this too.
Comment #9
damiankloip CreditAttribution: damiankloip commentedI would say this is a dependency for #941970: Only set router rebuild needed when something related to routing actually changes now.
Comment #10
dawehnerAfaik this was was worked on in some other issue.
array(TRUE, 'views') is a little bit odd, can you elobarete why this is needed?
Comment #11
damiankloip CreditAttribution: damiankloip commentedSee Wim's comment in #6. If we have extension tags we get good flexibility to e.g. just clear extension:views tag and clear out plugin definitions, views data etc. Otherwise we have to truncate whole tables every time.
Comment #12
dawehnerOh I see, thank you!
Comment #14
damiankloip CreditAttribution: damiankloip commentedJust a reroll.
Comment #15
damiankloip CreditAttribution: damiankloip commentedComment #16
alexpottCommitted cce2380 and pushed to 8.x. Thanks!