BanIpmanager doesn't has an interface. Create one and use the interface instead of the class as a parameter in the BanSubscribe, BanAdmin and BenDelete classes' constructors.

CommentFileSizeAuthor
#4 banipmanagerinterface-2225685-4.patch6.57 KBakozma
#2 banipmanagerinterface-2225685-2.patch7.16 KBakozma
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akozma’s picture

akozma CreditAttribution: akozma commented
Assigned: Unassigned » akozma
akozma’s picture

akozma CreditAttribution: akozma commented
Status: Active » Needs review
FileSize
banipmanagerinterface-2225685-2.patch7.16 KB

The interface is created.

Status: Needs review » Needs work

The last submitted patch, 2: banipmanagerinterface-2225685-2.patch, failed testing.

akozma’s picture

akozma CreditAttribution: akozma commented
Status: Needs work » Needs review
FileSize
banipmanagerinterface-2225685-4.patch6.57 KB

Re-roll

skipyT’s picture

skipyT CreditAttribution: skipyT commented
Status: Needs review » Reviewed & tested by the community

  • Commit bee18ab on 8.x by alexpott: 
    Issue #2225685 by ocsilalala: BanIpManager doesn't have interface.
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed bee18ab and pushed to 8.x. Thanks!

+++ b/core/modules/ban/lib/Drupal/ban/BanIpManager.php
@@ -79,16 +64,9 @@ public function unbanIp($id) {
diff --git a/core/modules/ban/lib/Drupal/ban/BanIpManagerInterface.php b/core/modules/ban/lib/Drupal/ban/BanIpManagerInterface.php

diff --git a/core/modules/ban/lib/Drupal/ban/BanIpManagerInterface.php b/core/modules/ban/lib/Drupal/ban/BanIpManagerInterface.php
new file mode 100755

new file mode 100755
index 0000000..331554b

index 0000000..331554b
--- /dev/null

--- /dev/null
+++ b/core/modules/ban/lib/Drupal/ban/BanIpManagerInterface.php

New files should be 644 - I've fixed this during commit.

akozma’s picture

akozma CreditAttribution: akozma commented

Understood! Thank you alexpott!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.