Fix config test modules namespacing

There is a config_override_test module already but this is mis-named :)

Took a quick look at the patch ... the changes that are there look correct, though admittedly I don't have enough D8 experience to comment on the 'context' of the changes.

I didn't check to ensure that 'all' the instances were captured, but assuming they were, I think it's RTBC.

Gremy ... can you confirm that you've used grep or some other search mechanism to ensure that there are no other instances of the old test names left in the code?

The old modules are not removed by the patch in #4

The patch in #10 is still not deleting the files correctly.

We still have unwanted files in there:

.
├── config_events_test
│   ├── config_events_test.info.yml
│   ├── config_events_test.services.yml
│   └── lib
│       └── Drupal
│           └── config_events_test
│               └── EventSubscriber.php
├── config_existing_default_config_test
│   ├── config
│   │   └── system.cron.yml
│   └── config_existing_default_config_test.yml
├── config_integration_test
│   ├── config
│   │   ├── config_integration_test.settings.yml
│   │   ├── config_test.dynamic.config_integration_test.yml
│   │   └── schema
│   │       └── config_integration_test.schema.yml
│   └── config_integration_test.info.yml
├── config_other_module_config
│   ├── config
│   │   └── config_test.dynamic.other_module.yml
│   └── config_other_module_config.info.yml
├── config_other_module_config_test
│   ├── config
│   │   └── config_test.dynamic.other_module_test.yml
│   └── config_other_module_config_test.info.yml
├── config_override
│   ├── config_override.info.yml
│   └── lib
│       └── Drupal
│           └── config_override
│               ├── ConfigOverriderLowPriority.php
│               └── ConfigOverrider.php
├── config_override_test
│   ├── config
│   │   └── system.cron.yml
│   ├── config_override_test.info.yml
│   ├── config_override_test.services.yml
│   ├── config_override_test.yml
│   └── lib
│       └── Drupal
│           └── config_override_test
│               ├── ConfigOverriderLowPriority.php
│               └── ConfigOverrider.php
├── config_test
│   ├── config
│   │   ├── config_test.dynamic.dotted.default.yml
│   │   ├── config_test.noschema.yml
│   │   ├── config_test.no_status.default.yml
│   │   ├── config_test.schema_in_install.yml
│   │   ├── config_test.someschema.somemodule.section_one.subsection.yml
│   │   ├── config_test.someschema.somemodule.section_two.subsection.yml
│   │   ├── config_test.someschema.with_parents.yml
│   │   ├── config_test.someschema.yml
│   │   ├── config_test.system.yml
│   │   ├── config_test.types.yml
│   │   ├── language.config.de.config_test.system.yml
│   │   ├── language.config.en.config_test.system.yml
│   │   ├── language.config.fr.config_test.system.yml
│   │   └── schema
│   │       └── config_test.schema.yml
│   ├── config_test.hooks.inc
│   ├── config_test.info.yml
│   ├── config_test.local_actions.yml
│   ├── config_test.local_tasks.yml
│   ├── config_test.module
│   ├── config_test.routing.yml
│   └── lib
│       └── Drupal
│           └── config_test
│               ├── ConfigTestAccessController.php
│               ├── ConfigTestController.php
│               ├── ConfigTestFormController.php
│               ├── ConfigTestInterface.php
│               ├── ConfigTestListBuilder.php
│               ├── ConfigTestStorage.php
│               ├── Entity
│               │   ├── ConfigQueryTest.php
│               │   └── ConfigTest.php
│               ├── Form
│               │   └── ConfigTestDeleteForm.php
│               ├── TestInstallStorage.php
│               └── TestSchemaStorage.php
├── config_test_invalid_name
│   ├── config
│   │   ├── invalid_object_name.yml
│   │   └── schema
│   │       └── config_test_invalid_name.schema.yml
│   └── config_test_invalid_name.info.yml
└── Drupal
    └── config
        └── Tests
            └── Menu
                └── ConfigLocalTasksTest.php

37 directories, 57 files

+++ b/core/modules/config/tests/config_override_test/lib/Drupal/config_override_test/ConfigOverrider.php
@@ -0,0 +1,41 @@
+        $overrides = $overrides + array('system.site' => array('name' => 'ZOMG overridden site name'));

LOL

Use git mv to move the files and directories to their new names/locations. This will simultaneously make the changes on your filesystem and update the git index, so that when you create a patch, the old cruft is deleted. Edit: Note also that if you are diffing in the same branch without a commit, you'll need to use git diff --staged to ensure staged changes are included in the diff.

Rolled patch that moves / removes files as desired.

Patch removes completely invalid config_test_invalid_name test module as it is unused.

Re-rolled for PSR4

17: 2225485.17.patch queued for re-testing.

diff --git a/core/modules/config/tests/config_test_invalid_name/config/schema/config_test_invalid_name.schema.yml b/core/modules/config/tests/config_test_invalid_name/config/schema/config_test_invalid_name.schema.yml
deleted file mode 100644

Why is this removed?

Because the test that used it was removed in #2082117: Install default config only when the owner and provider modules are both enabled since the very nature of that test became impossible. You can only install configuration that begins with a currently installed or being installed extension name.

Thanks for discussing this on IRC, so we digged to the bottom of it :) All righto, looks good then.

Committed/pushed to 8.x, thanks!