Problem/Motivation

The delete tab for aggregator feeds does not appear because of wrong yaml key (tab_root_id instead of base_route)

Proposed resolution

Fix, add a test

Remaining tasks

Commit

User interface changes

The Delete tab now actually appears

API changes

None

Original report by @ParisLiakos

Yes, i missed #2107531: Improve DX of local task YAML definitions, but thats ok because now i have to add a test :P

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ParisLiakos’s picture

Status: Active » Needs review
FileSize
1.23 KB
ParisLiakos’s picture

Issue summary: View changes
ParisLiakos’s picture

Jalandhar’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch #3, needs to be updated.

SumeetJaggi’s picture

Status: Needs work » Needs review
Issue tags: +#SprintWeekend2015
FileSize
1.27 KB

Patch rerolled!

SumeetJaggi’s picture

Issue tags: -#SprintWeekend2015 +SprintWeekend2015
manningpete’s picture

Issue tags: -Needs reroll

Patch applies.

ParisLiakos’s picture

Status: Needs review » Reviewed & tested by the community

thanks for the reroll

ParisLiakos’s picture

Issue summary: View changes
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 5297f9e and pushed to 8.0.x. Thanks!

  • alexpott committed 5297f9e on 8.0.x
    Issue #2224951 by ParisLiakos, Sumeet Jaggi: Aggregator delete local...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.