Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The delete tab for aggregator feeds does not appear because of wrong yaml key (tab_root_id instead of base_route)
Proposed resolution
Fix, add a test
Remaining tasks
Commit
User interface changes
The Delete tab now actually appears
API changes
None
Original report by @ParisLiakos
Yes, i missed #2107531: Improve DX of local task YAML definitions, but thats ok because now i have to add a test :P
Comment | File | Size | Author |
---|---|---|---|
#5 | drupal-aggregator_local_tasks-2224951-5.patch | 1.27 KB | SumeetJaggi |
#3 | drupal-aggregator_local_tasks-2224951-3.patch | 1.15 KB | ParisLiakos |
#1 | drupal-aggregator_local_tasks-2224951.patch | 1.23 KB | ParisLiakos |
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedComment #2
ParisLiakos CreditAttribution: ParisLiakos commentedComment #3
ParisLiakos CreditAttribution: ParisLiakos commentedreroll
Comment #4
Jalandhar CreditAttribution: Jalandhar commentedPatch #3, needs to be updated.
Comment #5
SumeetJaggi CreditAttribution: SumeetJaggi commentedPatch rerolled!
Comment #6
SumeetJaggi CreditAttribution: SumeetJaggi commentedComment #7
manningpete CreditAttribution: manningpete commentedPatch applies.
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedthanks for the reroll
Comment #9
ParisLiakos CreditAttribution: ParisLiakos commentedComment #10
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 5297f9e and pushed to 8.0.x. Thanks!