Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As part of #2031717: Make entity module not required let's start with moving all UI related stuff to field_ui module. As discussed over there field ui module really is an entity UI module (besides the name which can be fixed at any time later on).
Comment | File | Size | Author |
---|---|---|---|
#26 | 2224395-26.patch | 35.9 KB | Berdir |
#17 | 2224395-17.patch | 35.91 KB | swentel |
Comments
Comment #1
effulgentsia CreditAttribution: effulgentsia commentedRaising priority to match that of the parent issue.
Comment #2
blueminds CreditAttribution: blueminds commentedMoving all UI related code basically means moving whole module as the entity module now deals only with form/view/display modes. Or am I missing something?
Comment #3
Bojhan CreditAttribution: Bojhan commentedShouldn't this just be Entity UI module then?
Comment #4
dixon_I'll take a stab at this today at the extended code sprint in Austin.
Comment #5
dixon_Here's my first stab at this, put together on the flight home from Austin.
Comment #7
dixon_Comment #9
dixon_Re-rolling to keep up with HEAD.
Comment #10
dixon_Comment #11
BerdirRe-roll.
Comment #12
fagoNoticed the patch does not apply any more - so re-rolled it to account for the menu links file name changes.
The patch looks good in general, however I'm wondering whether there is a reason that the permission has not been moved yet?
Comment #14
fago#2031717: Make entity module not required is already ready and covers API changes so it should move first. Then, this one can do the rest (UI) and remove the module. Updating title.
Comment #15
swentel CreditAttribution: swentel commentedDisplay Modes doesn't show up yet at admin/structure - all the rest should be fine. Do we want to rename the prefixes in routing to field_ui as well ?
Comment #17
swentel CreditAttribution: swentel commentedShould fix the test, menu items are available again. Renamed the prefixes to field_ui for now for consistency.
Comment #18
andypostlooks good
Comment #19
andypostThe question of help here could be addressed in [2332687]
this hook_help() part is removed here but it looks useful...
Comment #20
BerdirYeah, most of that explanation is about what entities are, which had never anything to do with this module, what I already tried to explain in the issue that added entity_help(). Agreed we shouldn't lose it and it should probably be addressed here not a follow-up.
With all code and concepts being moved to components, hook_help() and the current per-module help system simply doesn't work anymore ;)
Comment #21
swentel CreditAttribution: swentel commentedThe part about managing view and form modes has been moved to field ui though. As Berdir also notes, the other help text is not relevant IMO.
Comment #22
swentel CreditAttribution: swentel commentedman, this is wrong .. url('entity.entity_view_mode_list' should be field_ui. ..
Comment #23
swentel CreditAttribution: swentel commentedWait, that is fine (I copy pasted from the previous patch)
Comment #24
fagoPatch looks good, yep.
How nice having no prefix foo changing everyhting!
Comment #26
BerdirPatch applied fine with git apply -3.
Comment #27
catchCommitted/pushed to 8.0.x, thanks!
RIP Entity module, again.