According to DiscoveryInterface, it has to return NULL if the plugin is not found. Right no array() is returned what is bogus. Attached patch fixes that.

CommentFileSizeAuthor
#9 drupal_2220259_9.patch1.29 KBXano
#4 d8_definition_null.patch1.4 KBfago
d8_plugin_manager_get_definition.patch471 bytesfago
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, d8_plugin_manager_get_definition.patch, failed testing.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
CreditAttribution: mr.baileys commented
Status: Needs work » Needs review

d8_plugin_manager_get_definition.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, d8_plugin_manager_get_definition.patch, failed testing.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs work » Needs review
FileSize
d8_definition_null.patch1.4 KB
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs review » Reviewed & tested by the community

Beautiful!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs review 
+++ b/core/modules/datetime/lib/Drupal/datetime/Plugin/Field/FieldType/DateTimeItem.php
@@ -46,7 +46,7 @@ public static function propertyDefinitions(FieldDefinitionInterface $field_defin
-    $properties['date'] = DataDefinition::create('datetime_computed')
+    $properties['date'] = DataDefinition::create('any')

Is that intentional?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Yes, that bug is exposed by this patch. There is no datetime_computed plugin.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/datetime/lib/Drupal/datetime/Plugin/Field/FieldType/DateTimeItem.php
diff --git a/sites/default/default.settings.php b/sites/default/default.settings.php
old mode 100644
new mode 100755

This seems unintentional.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
drupal_2220259_9.patch1.29 KB
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: drupal_2220259_9.patch, failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Reviewed & tested by the community

The tests fail because HEAD is broken.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

9: drupal_2220259_9.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit b5ac743 on 8.x by webchick: 
    Issue #2220259 by Xano, fago: DefaultPluginManager::getDefinition() does...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.