Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Updated: Comment 0
Problem/Motivation
@See image and title
If you have your language as part of the URL the main request generates cache IDs per language, though the subtree access fails.
Proposed resolution
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff.txt | 2.45 KB | jessebeach |
#5 | toolbar-langcode-403-2218313-tests-fail.patch | 2.94 KB | jessebeach |
#5 | toolbar-langcode-2218313-5.patch | 7.09 KB | jessebeach |
#1 | toolbar-2218313-1.patch | 4.64 KB | dawehner |
00002182.png | 878.58 KB | dawehner |
Comments
Comment #1
dawehnerThe problem is that the langcode does not get passed along to the subtree request. This seems to be one way to solve it. Maybe though we could also somehow encode this directly into the hash.
Comment #2
YesCT CreditAttribution: YesCT commentedadding d8mi since it has to do with languages.
adding JavaScript tag since it touches a javascript file, and @nod_ asked all issues that touch js files get that tag. (#2219493: Add search for issues with patches that touch certain file types (javascript, css, ...) or files automates/helps with that)
Comment #3
Wim LeersAssigning to Jesse Beach for feedback.
Comment #4
Gábor HojtsyLooks good on a code review.
The only thing I noticed on code review is a missing empty line between @param and @return.
Comment #5
jessebeach CreditAttribution: jessebeach commentedifrik and I added a new test and extend the
testSubtreesJsonRequest
to include langcode. We've included a fail version with just the extended testing and a new patch with the testing.Comment #8
Sam152 CreditAttribution: Sam152 commented5: toolbar-langcode-2218313-5.patch queued for re-testing.
Comment #9
olli CreditAttribution: olli commentedLooks like #2146035: drupalSettings.path.pathPrefix does not contain the language identifier could fix this issue.
Comment #10
jessebeach CreditAttribution: jessebeach commentedThank you for the cross link olli!
I consider the code in this issue sufficient to address the original bug report. dawehner's patch in #1 solved the issue and #5 just adds additional test coverage.
I'll leave a note in #2146035: drupalSettings.path.pathPrefix does not contain the language identifier to look specifically at the Toolbar code if that issue goes further.
Comment #12
alexpottCommitted ddc0b0b and pushed to 8.x. Thanks!
Fixed during commit