Updated: Comment #0

Problem/Motivation

The _editor_get_processed_text_fields() assumes that only "configurable fields use text processing.
Taxonomy description and probably other base fields could use text fields for base fields.
Also we are going to remove "configurable" setting from field definition in #2191709: Remove the "configurable" flag on field types

Proposed resolution

Properly iterate over entity fields for text_processing setting or check that provider of the field is text module.

Remaining tasks

Find right way to implement this function.

User interface changes

no

API changes

no

CommentFileSizeAuthor
#2 2218219-text-processing-2.patch1.38 KBandypost
#2 interdiff.txt408 bytesandypost
#1 2218219-text-processing-1.patch1.14 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review
FileSize
2218219-text-processing-1.patch1.14 KB

Suppose this one is enough for start

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
interdiff.txt408 bytes
2218219-text-processing-2.patch1.38 KB

Also remove unused use statement

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Awesome cleanup!

Yes, taxonomy terms now have a text field as a base field, so we should support this there and other similar cases.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Very nice clean-up indeed :) RTBC++

Thanks!

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Issue tags: +Entity Field API
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 99c739a and pushed to 8.x. Thanks!

  • Commit 99c739a on 8.x by alexpott: 
    Issue #2218219 by andypost: _editor_get_processed_text_fields() should...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.