Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#1862202: Objectify the language system was a very big patch and that's probably why coding style did suffer a little bit.
Comment | File | Size | Author |
---|---|---|---|
#18 | interdiff.txt | 2.75 KB | LinL |
#18 | 2212411-code-style-cleanup-of-language-system-18.patch | 5.97 KB | LinL |
Comments
Comment #1
znerol CreditAttribution: znerol commentedComment #2
joelpittetNice cleanup!
Comment #3
joelpittetjust noticed.
Needs a period at the end.
Worth having a second look if there is anything else.
Comment #4
znerol CreditAttribution: znerol commentedRight, rerolled.
Comment #5
joelpittetThanks for the quick fix:) Back to RTBC.
Comment #6
webchickTriaging the queue a bit.
Comment #8
znerol CreditAttribution: znerol commented4: 2212411-code-style-cleanup-of-language-system-3.patch queued for re-testing.
Comment #9
znerol CreditAttribution: znerol commentedLast test-failure was a test-bot-failure. Set this to RTBC again.
Comment #11
znerol CreditAttribution: znerol commentedTagging it for a reroll.
Comment #12
LinL CreditAttribution: LinL commentedRerolled.
Comment #14
visabhishek CreditAttribution: visabhishek commented12: 2212411-code-style-cleanup-of-language-system-12.patch queued for re-testing.
Comment #15
plachJust a few remarks, otherwise looks good, thanks.
In the entity system we call the initial values param
$values
. I'd do the same for consistency.lol
Am I wrong or now "returned." fits in the upper line?
Comment #16
Claudis CreditAttribution: Claudis commentedPatch from #12 applied. Tests cleanly.
Comment #17
LinL CreditAttribution: LinL commentedThanks @plach. Here's a reroll.
Comment #18
LinL CreditAttribution: LinL commentedFound another comment that was running over 80 chars and a couple of typos, so here it is again.
Comment #19
plachThanks!
Comment #20
webchickOh cool. This isn't nearly as big of a patch as I was fearing. :) I think it's cool to let this go in despite not being in a "disruptive patch period" since most of these fixes are pretty small and self-contained.
Committed and pushed to 8.x. Thanks!