It looks like there is some specific styling on the tour tab in the toolbar that's increasing the height of the toolbar. Ideally there shouldn't be any unique styling, most of the tabs look the same.

CommentFileSizeAuthor
#9 drupal-tour-button-2208731-9.patch6.88 KBLewisNyman
#2 Screenshot 2014-03-04 08.00.33.png42.62 KBlarowlan
#2 Screenshot 2014-03-04 07.58.42.png10.97 KBlarowlan
#2 Screenshot 2014-03-04 07.54.02.png10.05 KBlarowlan
#2 tour-button.patch478 byteslarowlan
Content__Content____Site-Install.jpg119.56 KBLewisNyman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue tags: +Tour

Adding tag

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review
FileSize
tour-button.patch478 bytes
Screenshot 2014-03-04 07.54.02.png10.05 KB
Screenshot 2014-03-04 07.58.42.png10.97 KB
Screenshot 2014-03-04 08.00.33.png42.62 KB

Every other toolbar item is an a tag, except tour which was a button.
Changing it to an a seems to fix the padding issue.
Tour still works.

before



after

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

there is some css and js in tour that refer to a button element, so will need to update those too

paulh’s picture

paulh CreditAttribution: paulh commented

- Reviewed code: no obvious issues.
- Applied patch, tested Tour functionality on view: Content and view: Files. Padding issue resolved without impact on Tour functionality.
- Not sure about the ref in comment #3 to css and js and whether that's pertinent to this patch.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Needs work

tour button is a button, not a link. Let's tweak the CSS to fix this. There is no href, <a> is not the right tag.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Issue tags: +accesibility

Yeah we shouldn't rely on a specific element for styling, which is part of out CSS standards. Let's make sure the CSS is generic enough to cover any element we choose, for accessibility reasons.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs work » Needs review

Ok, I tried adding a common class to replace the element selectors. It got kind of hairy because modules seem to pass through the attributes in different structures? I've never heard of #options outside of the form api...

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

No patch?

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
FileSize
drupal-tour-button-2208731-9.patch6.88 KB

Whoops

Coornail’s picture

Coornail CreditAttribution: Coornail commented
Status: Needs review » Reviewed & tested by the community

Patch looks good, it does fix the padding problem.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: drupal-tour-button-2208731-9.patch, failed testing.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs work » Needs review

9: drupal-tour-button-2208731-9.patch queued for re-testing.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

  • Commit 2f13993 on 8.x by webchick: 
    Issue #2208731 by LewisNyman, larowlan: Tour tab increases the height of...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Issue tags: -accesibility +Accessibility