Updated: Comment #N

Problem/Motivation

Replying to a forum comment results in Call to a member function isSubclassOf() on a non-object in CommentManager.php on line 113.

Steps:
Create a node with threaded commenting
Create a comment
Attempt to reply to first comment by clicking reply link.
Fatal.

Proposed resolution

Expand tests
Fix

Remaining tasks

Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#3 forum-fatal-2207219.pass_.patch1.56 KBlarowlan
#2 forum-fatal-2207219.fail_.patch720 byteslarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: Unassigned » larowlan

Working on test

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review
FileSize
forum-fatal-2207219.fail_.patch720 bytes

Test to catch, fix coming

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
Related issues: +#2028025: Expand CommentInterface to provide methods
FileSize
forum-fatal-2207219.pass_.patch1.56 KB

This one caused by #2028025: Expand CommentInterface to provide methods

Here's the fix

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: larowlan » Unassigned

The last submitted patch, 2: forum-fatal-2207219.fail_.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

It is just a typo so RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.