Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.API page: https://api.drupal.org/api/drupal/core%21modules%21simpletest%21lib%21Dr...
Enter a descriptive title (above) relating to protected function WebTestBase::drupalPlaceBlock, then describe the problem you have found:
There's some documentation in WebTestBase::drupalPlaceBlock() that says:
Note: Until this can be done programmatically, the active user account must have permission to administer blocks.
But it looks to me as though the code is programmatic and would not require this any more. Should this be removed?
For the moment, moving to simplest component for decision; afterwards you can move to "documentation" component and mark "Novice" for the actual patch if it is OK to remove this documentation.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2207197-drupalplaceblock-obsolete-docs-5.patch | 1.78 KB | longwave |
| #2 | obsolete-doc-2207197-2.patch | 723 bytes | andrei.dincu |
Comments
Comment #1
andrei.dincu CreditAttribution: andrei.dincu commentedComment #2
andrei.dincu CreditAttribution: andrei.dincu commentedComment #3
andrei.dincu CreditAttribution: andrei.dincu commentedComment #4
jhodgdonThe patch looks fine to me, but we still need to figure out if the text should be removed.
Comment #5
longwaveNewDefaultThemeBlocksTest is a relatively simple test that logs in before calling drupalPlaceBlock(). Let's see what happens if we remove the drupalLogin() and drupalLogout() calls.
If this passes, we should probably consider removing similar login/logout calls and "administer blocks" permissions in tests where they are no longer required.
Comment #6
jhodgdonI am not sure that's a valid test of this. I kind of thought that if you never login/logout, WebTestBase acts as if you are user 1, but maybe not?
Comment #7
longwaveI thought you had to use
$this->drupalLogin($this->root_user);to log in as user 1? Otherwise, tests start off with you being anonymous?Comment #8
longwaveSee \Drupal\block\Tests\BlockHtmlTest which deliberately logs in as $this->root_user, and arguably would have been a better example to use to test this issue.
Comment #9
jhodgdonYes, actually I think you are correct, at least for 8.x.
OK, I think this is ready to go, unless we should remove some other unnecessary logins... Thanks!
Comment #10
Dries CreditAttribution: Dries commentedCommitted to 8.x.