Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Status: Active » Needs review
FileSize
7.19 KB

Seems easy enough :)

Dropped the ViewsDiscoveryHandler thing.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +VDC, +Plugin system

I think there were other issues about improving ViewsHandlerManager, but I can't find them, and this is fine.
Getting rid of ViewsHandlerDiscovery is especially nice. That used to contain a lot more logic, but using $this->defaults is much nicer.

damiankloip’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/ViewsHandlerManager.php
@@ -45,18 +44,23 @@ class ViewsHandlerManager extends PluginManagerBase {
+      'plugin' => $handler_type,

Sorry, this changes 'plugin_type' to 'plugin'.

Otherwise, this patch look great. Moving stuff to the defaults is indeed a much nicer thing.

tim.plunkett’s picture

Whoops. But wait, why did it pass?!

damiankloip’s picture

We don't really use it.

Berdir’s picture

Status: Needs work » Needs review
FileSize
7.19 KB
620 bytes

A feature that's not covered by tests doesn't exist ;)

damiankloip’s picture

It's not really a feature. Its just something that's there :)

damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

Yes, this is RTBC.

Berdir’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
7.56 KB
5.31 KB
damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

And again..

damiankloip’s picture

9: views-handler-2204635-9.patch queued for re-testing.

dawehner’s picture

This improves DX (maybe this helps to get this in faster)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 1d1c63d and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.