There are two default plugin bag implementations in Drupal/Component, and neither of them need to reside there. Timplunkett and I discussed this a little recently and he suggested moving them out, I completely support that, so here's a patch.

Eclipse

CommentFileSizeAuthor
#9 2204307-9.patch10.97 KBEclipseGc
#7 2204307-7.patch11.17 KBEclipseGc
#5 2204307-5.patch9.38 KBEclipseGc
#4 2204307-4.patch16 KBEclipseGc
core_pluginbags.patch9.02 KBEclipseGc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, core_pluginbags.patch, failed testing.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Needs work » Needs review

core_pluginbags.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, core_pluginbags.patch, failed testing.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Needs work » Needs review
FileSize
2204307-4.patch16 KB

Let's see how this one fairs.

Eclipse

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
FileSize
2204307-5.patch9.38 KB

ok, this one utilizes -M properly.

Eclipse

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Title: Move PluginBag Implementations to Core » Move PluginBag Implementations from \Drupal\Component to \Drupal\Core

I did a double take at the issue title :)

+++ b/core/modules/views/lib/Drupal/views/DisplayBag.php
index 735dd7b..721f3c5 100644
--- a/core/tests/Drupal/Tests/Component/Plugin/ConfigurablePluginBagTest.php

--- a/core/tests/Drupal/Tests/Component/Plugin/ConfigurablePluginBagTest.php
+++ b/core/tests/Drupal/Tests/Component/Plugin/ConfigurablePluginBagTest.php

+++ b/core/tests/Drupal/Tests/Component/Plugin/ConfigurablePluginBagTest.php
index 1dc33d9..cf2c9b5 100644
--- a/core/tests/Drupal/Tests/Component/Plugin/DefaultPluginBagTest.php

--- a/core/tests/Drupal/Tests/Component/Plugin/DefaultPluginBagTest.php
+++ b/core/tests/Drupal/Tests/Component/Plugin/DefaultPluginBagTest.php

+++ b/core/tests/Drupal/Tests/Component/Plugin/DefaultPluginBagTest.php
index 65bba15..fa0d367 100644
--- a/core/tests/Drupal/Tests/Component/Plugin/DefaultSinglePluginBagTest.php

--- a/core/tests/Drupal/Tests/Component/Plugin/DefaultSinglePluginBagTest.php
+++ b/core/tests/Drupal/Tests/Component/Plugin/DefaultSinglePluginBagTest.php

+++ b/core/tests/Drupal/Tests/Component/Plugin/DefaultSinglePluginBagTest.php
index 461321d..8bdcdb9 100644
--- a/core/tests/Drupal/Tests/Component/Plugin/PluginBagTestBase.php

--- a/core/tests/Drupal/Tests/Component/Plugin/PluginBagTestBase.php
+++ b/core/tests/Drupal/Tests/Component/Plugin/PluginBagTestBase.php

We should move the tests as well.

After that, I'll absolutely RTBC this.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
FileSize
2204307-7.patch11.17 KB

Ok, moved the tests, hopefully this all passes!

Eclipse

Status: Needs review » Needs work

The last submitted patch, 7: 2204307-7.patch, failed testing.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
FileSize
2204307-9.patch10.97 KB

ooook... whatever trying again.

Eclipse

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Needs work » Needs review

oops

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Thanks, looks good!

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Title: Move PluginBag Implementations from \Drupal\Component to \Drupal\Core » [Change record updates] Move PluginBag Implementations from \Drupal\Component to \Drupal\Core
Priority: Normal » Major
Status: Reviewed & tested by the community » Active
Issue tags: +Missing change record

Asked for more info in IRC... while these don't have any Drupal-specific code in them (the typical reason we'd move something from Component => Core), they're definitely a Drupal 8 use-case and concept.

Committed and pushed to 8.x. Thanks!

Looks like we need some change record updates now: https://drupal.org/list-changes/published?keywords_description=Drupal\Component\Plugin\&to_branch=&version=&created_op=%3E%3D&created[value]=&created[min]=&created[max]= I don't know the tag for that.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Active » Fixed
Issue tags: -Missing change record

added a change record.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Title: [Change record updates] Move PluginBag Implementations from \Drupal\Component to \Drupal\Core » Move PluginBag Implementations from \Drupal\Component to \Drupal\Core

updating title.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.