This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.

Updated: Comment #0

Problem/Motivation

There are two 'name' case's in comment_tokens() in core/modules/comment/comment.tokens.inc

Proposed resolution

remove the first - since the second is better because getAuthorName() does the anonymous stuff

Remaining tasks

User interface changes

No.

API changes

No.

CommentFileSizeAuthor
#1 2203853-comment-token-1.patch849 bytessidharthap
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap commented
Status: Active » Needs review
FileSize
2203853-comment-token-1.patch849 bytes

Here is the patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Reviewed & tested by the community

Patch looks good, though the comment above the duplicate mentions #920056: [comment:name] duplicates [comment:author], and the latter should use format_username() and it looks like the patch there also solves this issue.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

That one is still hanging out as NR, and this one has been RTBC for a bit, so I think it's good to get this in.

Committed and pushed to 8.x. Thanks! Nice catch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.