The pecl YAML parser fails to parse core/modules/node/tests/modules/node_test_views/test_views/views.view.test_contextual_links.yml

CommentFileSizeAuthor
d8.test-view-yaml.patch693 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
Status: Needs review » Reviewed & tested by the community

Looks goooood.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

I wonder why this was not caught before.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Hm. Yes, me too. Do we need a separate test that runs all of our YAML through a validator of some kind? Or is Symfony's just simply more persmissive, so we'd only catch it on PECL?

In any case, committed and pushed to 8.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Symfony is okay with this - PECL is not so yep this is only catchable if we go with with PECL - but unfortunately we've found a few important differences that mean we can't go with PECL unless we get upstream changes in one of the them :(

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.