The “Skip to main content” link is not centered [#2202385]

At some point in time the styling for the “Skip to main content” link in Seven was knocked out a bit. Let's fix it.

Let's be aware of the toolbar when it's in it's vertical position to.

Comment	File	Size	Author
#7	Screenshot from 2014-03-12 19:38:57.png	51.48 KB	rob3000
#5	Screenshot from 2014-03-12 13:44:33.png	98.77 KB	rob3000
#4	interdiff-1-2.txt	378 bytes	martin107
#4	seven-skip-content-link-2202385-2.patch	445 bytes	martin107
#4
#2	seven-skip-content-link-2202385-1.patch	444 bytes	kjay
#2
	Screen Shot 2014-02-21 at 17.26.31.jpg	152.26 KB	LewisNyman

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

LewisNyman

he/him

CreditAttribution: LewisNyman commented 2 March 2014 at 15:30

Comment #2

kjay CreditAttribution: kjay commented 2 March 2014 at 16:21

Status:

Active

» Needs review

File	Size
seven-skip-content-link-2202385-1.patch	444 bytes

system.module.css is overriding the skip links on pseudo classes active and focus by putting the 'skip to main content' link's position attribute back to 'static'. To avoid breaking things elsewhere, have patched to use a more specific class selector for the skip to main content link on pseudo classes active, focus and hover.

Original issue where this problem crept in: https://drupal.org/node/897638

Comment #3

LewisNyman

he/him

CreditAttribution: LewisNyman commented 7 March 2014 at 16:40

Status:

Needs review

» Needs work

+++ b/core/themes/seven/style.css
@@ -64,6 +64,12 @@ ul.menu li.expanded {
+	position: absolute !important;

It looks like there is a whitespace error here. Make sure your text editor is configured to use two spaces instead of tabs.

Apart from that it looks fine. A bit of a shame we have to use !important

Comment #4

martin107 CreditAttribution: martin107 commented 7 March 2014 at 17:22

Status:

Needs work

» Needs review

File	Size
seven-skip-content-link-2202385-2.patch	445 bytes

interdiff-1-2.txt	378 bytes

whitespace removed.

Comment #5

rob3000 CreditAttribution: rob3000 commented 12 March 2014 at 05:47

File	Size
Screenshot from 2014-03-12 13:44:33.png	98.77 KB

i'm new to all this but i applied patch in comment #4. All works fine see attached.

Comment #6

LewisNyman

he/him

CreditAttribution: LewisNyman commented 12 March 2014 at 09:59

Hey Rob :) This bug is against the Seven theme, so you have to go to an admin page to test it out. I'm happy with the patch so once you've tested it works you can change the status to RTBC.