Fix serialization of the forum manager and dependency on current_user service [#2201659]

Updated: Comment #0

Problem/Motivation

Current user service going to be refactored and should be properly injected into services according #2180109-96: Change the current_user service to a proxy
Forum manager serialized with all its services and static caches

Proposed resolution

Extend forum manager from DependencySerialization and clean-up static cache like #2081585-70: [META] Modernize the History module
Update methods to accept user account as required argument.

Remaining tasks

file patch

User interface changes

API changes

tbd

Comment	File	Size	Author
#11	2201659-11.patch	5.65 KB	akozma
#11
#5	forum-mgr-serialization-2201659.1.patch	5.57 KB	larowlan
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

andypost

he/him

Russian

CreditAttribution: andypost commented 20 February 2014 at 22:34

Issue tags:

+Novice

suppose this could be simply grep'ed

Comment #2

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 21 February 2014 at 20:26

When is forum manager serialized?

Comment #3

andypost

he/him

Russian

CreditAttribution: andypost commented 21 February 2014 at 23:31

everytime when used in ajax forms

Comment #4

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 25 February 2014 at 06:50

Assigned:

Unassigned

» larowlan

working on this

Comment #5

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 25 February 2014 at 07:58

Assigned:	larowlan	» Unassigned
Status:	Active	» Needs review
Issue tags:	-Novice

File	Size
forum-mgr-serialization-2201659.1.patch	5.57 KB

Something like so?

Comment #6

andypost

he/him

Russian

CreditAttribution: andypost commented 25 February 2014 at 11:54

Status:

Needs review

» Reviewed & tested by the community

Sure, also spotted.

+++ b/core/modules/forum/lib/Drupal/forum/ForumManager.php
@@ -135,13 +137,12 @@ public function __construct(ConfigFactoryInterface $config_factory, EntityManage
     global $forum_topic_list_header;

this one is confusing, but out o scope

Comment #7

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 25 February 2014 at 21:32

Added #2205101: Weird use of globals for table header in Forum for the global

Comment #8

Dries CreditAttribution: Dries commented 5 March 2014 at 19:40

This patch looks good but what is the __sleep() and __wakeup() for?

Comment #9

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 6 March 2014 at 20:16

If an object is serialized, php calls wakeup function before unserializing. The sleep function is called before serializing. If forum manager is injected into a form, and that form uses caching (eg ajax) then forum manager gets serialized. This ensures it does so without keeping stale values.

Comment #10

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 8 March 2014 at 10:23

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs reroll

forum-mgr-serialization-2201659.1.patch no longer applies.

error: patch failed: core/modules/forum/lib/Drupal/forum/Controller/ForumController.php:82
error: core/modules/forum/lib/Drupal/forum/Controller/ForumController.php: patch does not apply
error: patch failed: core/modules/forum/lib/Drupal/forum/ForumManager.php:135
error: core/modules/forum/lib/Drupal/forum/ForumManager.php: patch does not apply
error: patch failed: core/modules/forum/lib/Drupal/forum/ForumManagerInterface.php:19
error: core/modules/forum/lib/Drupal/forum/ForumManagerInterface.php: patch does not apply