Follow up from #2095303: Rename 'field_entity' to 'field_config' and 'field_instance' to 'field_instance_config'

CommentFileSizeAuthor
#5 interdiff.txt2.85 KBplopesc
#5 rename_field_forbid-2201087-5.patch8.81 KBplopesc
#2 rename_field_forbid-2201087-2.patch8.48 KBplopesc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Issue summary: View changes
plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Active » Needs review
FileSize
rename_field_forbid-2201087-2.patch8.48 KB

Renaming hook and also FieldUpdateForbiddenException to FieldConfigUpdateForbiddenException

yched’s picture

yched CreditAttribution: yched commented

Thanks @plopesc.

While we're in there, we should add typehints to the params of hook_field_config_update_forbid() (phpdoc + example + implementations)

This being said, those would be hints on the interfaces, meaning it's going to clash with #2200821: Rename Fieldinterface and FieldInstanceInterface.
#2200821: Rename Fieldinterface and FieldInstanceInterface has a larger surface for conflicts / rerolls, so it might be best to get it in first, and then add the new interface names here ?

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Needs review » Postponed

Postponing on #2200821: Rename Fieldinterface and FieldInstanceInterface

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Postponed » Needs review
FileSize
rename_field_forbid-2201087-5.patch8.81 KB
interdiff.txt2.85 KB

New patch addressing suggestions in #3 once #2200821: Rename Fieldinterface and FieldInstanceInterface is in!

yched’s picture

yched CreditAttribution: yched commented

Looks good, thanks !
We'll now need a draft change notice before it can move to RTBC though.

Status: Needs review » Needs work

The last submitted patch, 5: rename_field_forbid-2201087-5.patch, failed testing.

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented

5: rename_field_forbid-2201087-5.patch queued for re-testing.

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented

Here is the change record draft: hook_field_update_forbid() and FieldUpdateForbiddenException renamed to hook_field_config_update_forbid() and FieldConfigUpdateForbiddenException

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Reviewed & tested by the community

Thanks! Streamlined the change notice a bit.

This should be good if green.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: rename_field_forbid-2201087-5.patch, failed testing.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Status: Needs work » Needs review

I cancelled that test and then sent it for a retest.

swentel’s picture

swentel CreditAttribution: swentel commented

5: rename_field_forbid-2201087-5.patch queued for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community

Should still be good - let's hope it doesn't run for 14 days again :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.